Fix missing return type for _getVersion()#1530
Fix missing return type for _getVersion()#1530Bellardia wants to merge 1 commit intophalcon:3.4.xfrom
Conversation
rudiservo
left a comment
There was a problem hiding this comment.
Phalcon 3.4 no longer maintainable.
It kind of is; we're running it in production on PHP 8.2. Whether or not you want these changes merged back is a choice from there. I have a much larger PR for full compatibility that there seemed to be interest for in discord, even if it only benefits a select few. |
|
Why have 3.4 in php8.2 and why haven't you upgraded yet to 5. There are other issues why I can't accept this, return types where only after php7.4 https://www.php.net/manual/en/language.types.declarations.php I hope you understand but time is limited, I would rather focus phalcon 5 for now, if you need something to make your upgrade easier just create an issue. |
|
All good, I actually totally understand, feel free to close. |
|
Current Phalcon5 is not just cosmetic, there are bug fixes, try it and let me know. |
We're still using 3.4.x on PHP 7.4
There's a type error caused by a missing return type that was added to Phalcon\Version.