feat!: rewrite to use cucumber messages #273

daantimmer · 2025-12-18T23:32:17Z

This (internal) rewrite is to make amp-cucumber-cpp-runner cucumber-messages compatible. Both during runtime and during formatting.

This will enable amp-cucumber-cpp-runner to be compatible with other, standalone, formatters.

… compatibility kit

…r to catch errors

…ta, doc-strings, empty, examples-tables and minimal

…ooks-beforeall-error, hooks, hooks-attachment and hooks-conditional compatibility tests

…ation exists

github-actions · 2025-12-18T23:44:33Z

✅⚠️MegaLinter analysis: Success with warnings

Descriptor	Linter	Files	Fixed	Errors	Warnings	Elapsed time
✅ ACTION	actionlint	6		0	0	0.25s
✅ CPP	clang-format	185	0	0	0	1.25s
✅ DOCKERFILE	hadolint	1		0	0	0.27s
✅ JSON	jsonlint	8		0	0	0.2s
✅ JSON	prettier	8	6	0	0	0.46s
⚠️ MARKDOWN	markdownlint	6	3	14	0	0.87s
✅ MARKDOWN	markdown-table-formatter	6	3	0	0	0.26s
✅ REPOSITORY	git_diff	yes		no	no	0.03s
✅ REPOSITORY	grype	yes		no	no	28.0s
✅ REPOSITORY	ls-lint	yes		no	no	0.06s
✅ REPOSITORY	secretlint	yes		no	no	2.16s
✅ REPOSITORY	syft	yes		no	no	1.25s
✅ REPOSITORY	trivy	yes		no	no	5.16s
✅ REPOSITORY	trivy-sbom	yes		no	no	0.11s
✅ REPOSITORY	trufflehog	yes		no	no	2.18s
⚠️ SPELL	lychee	83		1	0	4.3s
✅ YAML	prettier	10	0	0	0	0.5s
✅ YAML	v8r	10		0	0	6.73s
✅ YAML	yamllint	10		0	0	0.49s

Detailed Issues

⚠️ SPELL / lychee - 1 error

[404] https://github.com/yourname/amp-cucumber-cpp-runner.git | Network error: Not Found
📝 Summary
---------------------
🔍 Total..........155
✅ Successful.....154
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1

Errors in CONTRIBUTING.md
[404] https://github.com/yourname/amp-cucumber-cpp-runner.git | Network error: Not Found

⚠️ MARKDOWN / markdownlint - 14 errors

CHANGELOG.md:26 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:38 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:47 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:53 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:61 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:65 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:70 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:79 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:90 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:98 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:102 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:127 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:134 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
README.md:114 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

Documentation: Custom Flavors
Command: npx mega-linter-runner@9.3.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

github-actions · 2025-12-18T23:51:59Z

Test Results

27 tests - 1 27 ✅ - 1 27s ⏱️ +24s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit de69483. ± Comparison against base commit 42ee292.

This pull request removes 6 and adds 5 tests. Note that renamed tests count towards both.

test.bats ‑ Missing mandatory feature argument
test.bats ‑ Missing mandatory report argument
test.bats ‑ Second feature file does not overwrite success with an undefined status
test.bats ‑ Test the asterisk keyword - will fail
test.bats ‑ Test unused step reporting
test.bats ‑ Undefined tests

test.bats ‑ Second feature file does not overwrite success with an ■ status
test.bats ‑ Test nested steps
test.bats ‑ Test the asterisk keyword
test.bats ‑ Test usage formatter
test.bats ‑ ■ tests

♻️ This comment has been updated with latest results.

.vscode/launch.json

…r-only

Copilot

Pull request overview

Copilot reviewed 291 out of 416 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 291 out of 414 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

daantimmer · 2026-01-23T16:28:40Z

@alextech I am nearing completion of this PR.

Do you happen to have any remarks before I would merge?

…matting

… Argument, Errors, Expression, ParameterRegistry

…stency

…tency and remove unused Polyfill.hpp

… tag_expression files

…lication and Timestamp files

…nsistency

…ability

…r failed tests

Copilot

Pull request overview

Copilot reviewed 291 out of 419 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

cucumber_cpp/library/engine/Table.cpp:1

This file appears to be a header file (with header guards) but has a .cpp extension. This is a mismatch - either rename to .hpp or remove the header guards if this is meant to be a source file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-23T22:36:00Z

cucumber_cpp/library/cucumber_expression/Argument.cpp

+#include "cucumber_cpp/library/cucumber_expression/ParameterRegistry.hpp"
+#include "fmt/format.h"
+#include <cstddef>
+#include <format>


The <format> header is included but never used. All formatting is done with fmt::format. Remove this unused include.

Suggested change

#include <format>

…oved clarity in SourceLocationOrder

sonarqubecloud · 2026-01-23T23:21:59Z

Quality Gate passed

Issues
101 New issues
7 Accepted issues

Measures
0 Security Hotspots
84.1% Coverage on New Code
0.4% Duplication on New Code

See analysis details on SonarQube Cloud

daantimmer added 22 commits December 8, 2025 12:44

feat!: rewrite to use cucumber messages

1457b95

enable ccache

e8e9362

disable the build of shared libs

792332e

disable position independent code generation for jbeder/yaml-cpp

e8c96aa

add additional launch tags

48d99c6

add first version (empty, minimal and data-tables are enabled) of the…

1ae9468

… compatibility kit

refactored a lot of code

10137be

removed unused files

7ac6e9c

update devcontainers for CI

77b4762

removed agauniyal/rang from dependencies

50a2bce

cleanup Application

4054607

sanitize and dump actual and expected json

45a4380

set option variables for dependencies as cache variables

958e05c

fix grouping for string parameter

6eb2da0

use ScopedFakeTestPartResultReporter instead of EmptyTestEventListene…

ece0b62

…r to catch errors

Enable the following compatibility tests: ambiguous, backgrounds, cda…

6f1f4c8

…ta, doc-strings, empty, examples-tables and minimal

add examples-tables-attachment compatibility test

07a77d7

add attachments compatibility test

028dcc5

enabled examples-tables-undefined and global-hooks compatibility test

640986f

Added global-hooks-afterall-error, global-hooks-attachments, global-h…

cbb2f0c

…ooks-beforeall-error, hooks, hooks-attachment and hooks-conditional compatibility tests

add all compatibility checks by default regardless if a cpp implement…

dfe7157

…ation exists

add hooks-named, hooks-skipped and hooks-undefined compatibility tests

de2aaeb

daantimmer mentioned this pull request Dec 18, 2025

feat: ndjson reporting #240

Closed

15 tasks

daantimmer added 2 commits December 18, 2025 23:40

add multiple-features and multiple-features-reverses compatibility tests

d1a3e52

Merge branch 'main' into feature/rewrite-to-use-cucumber-messages

cad1bcf

daantimmer added 3 commits December 19, 2025 09:46

fix clang-msvc build

83c6e5a

fix clang-msvc build

13484a5

fix MSVC build

c7ee029

github-actions bot reviewed Jan 23, 2026

View reviewed changes

.vscode/launch.json Show resolved Hide resolved

feat: update fmt library linkage to use fmt::fmt instead of fmt-heade…

9766418

…r-only

Copilot AI review requested due to automatic review settings January 23, 2026 14:05

Copilot AI reviewed Jan 23, 2026

View reviewed changes

daantimmer added 7 commits January 23, 2026 14:31

feat: update test for Step to check dataTable access

d7aa5d2

fix: correct variable name from linaege to lineage in Query.cpp

8506b7e

feat: remove Join utility functions from support library

27ba908

feat: enable all formatters for compatibility tests

fcd6ac2

fix: add null check for test_case_started_id in HandleAttachment

1728fc9

fix: add check for empty testStepFinishedAndTestSteps in Query.cpp

85d5b33

fix: add null check for step_definition_ids in UsageFormatter

9ad849e

Copilot AI review requested due to automatic review settings January 23, 2026 16:26

Copilot AI reviewed Jan 23, 2026

View reviewed changes

daantimmer and others added 12 commits January 23, 2026 16:44

fix: update step_definition_ids access to use value() for better clarity

a53f3d6

refactor: replace std::format with fmt::format for consistency in for…

92d8e36

…matting

refactor: replace std::format with fmt::format for consistency across…

b26b67a

… Argument, Errors, Expression, ParameterRegistry

refactor: replace std::format with fmt::format in Query.cpp for consi…

b51cee3

…stency

refactor: replace std::format with fmt::format in Body.cpp for consis…

9c067ad

…tency and remove unused Polyfill.hpp

refactor: replace std::format with fmt::format for consistency across…

11514b2

… tag_expression files

refactor: replace std::format with fmt::format for consistency in App…

fc729ad

…lication and Timestamp files

refactor: include fmt/chrono.h for consistency in Timestamp.cpp

429f716

refactor: update include path for fmt/format.h in Argument.cpp for co…

65b4b02

…nsistency

refactor: enhance exception message formatting in FormatMessages.cpp

f2dff72

refactor: demangle exception type names in Body.cpp for improved read…

1a8d52c

…ability

refactor: add scenario for exception throwing and update test tags fo…

b764e26

…r failed tests

Copilot AI review requested due to automatic review settings January 23, 2026 22:35

Copilot AI reviewed Jan 23, 2026

View reviewed changes

refactor: replace std::forward_as_tuple with std::make_tuple for impr…

de69483

…oved clarity in SourceLocationOrder

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: rewrite to use cucumber messages #273

feat!: rewrite to use cucumber messages #273

Uh oh!

daantimmer commented Dec 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

daantimmer commented Jan 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

sonarqubecloud bot commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat!: rewrite to use cucumber messages #273

Are you sure you want to change the base?

feat!: rewrite to use cucumber messages #273

Uh oh!

Conversation

daantimmer commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅⚠️MegaLinter analysis: Success with warnings

Detailed Issues

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

daantimmer commented Jan 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 23, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daantimmer commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading