-
Notifications
You must be signed in to change notification settings - Fork 7
ci: fix update dependencies #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes issues in the dependency update workflow and improves release notes handling. It corrects the APT requirements file pattern matching to be more flexible, and prevents potential issues with excessively large release notes by implementing truncation logic.
Changes:
- Updated the APT requirements file pattern to match files without requiring a dash separator
- Added truncation logic for release notes bodies exceeding 32,768 characters
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/update-dependencies.yml |
Removed dash requirement from apt-requirements file pattern |
.github/actions/update-vscode-extensions/update-vscode-extensions.sh |
Added release notes body size validation and truncation |
.github/actions/update-vscode-extensions/update-vscode-extensions.sh
Outdated
Show resolved
Hide resolved
.github/actions/update-vscode-extensions/update-vscode-extensions.sh
Outdated
Show resolved
Hide resolved
.github/actions/update-vscode-extensions/update-vscode-extensions.sh
Outdated
Show resolved
Hide resolved
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 20 | 0 | 0 | 0.49s | |
| ✅ DOCKERFILE | hadolint | 3 | 0 | 0 | 0.63s | |
| ✅ GHERKIN | gherkin-lint | 6 | 0 | 0 | 2.41s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.45s | |
| ✅ JSON | prettier | 21 | 4 | 0 | 0 | 0.52s |
| ✅ JSON | v8r | 21 | 0 | 0 | 7.33s | |
| ✅ MARKDOWN | markdownlint | 12 | 0 | 0 | 0 | 0.88s |
| ✅ MARKDOWN | markdown-table-formatter | 12 | 0 | 0 | 0 | 0.24s |
| ✅ REPOSITORY | checkov | yes | no | no | 16.95s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 0.51s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| ✅ REPOSITORY | grype | yes | no | no | 27.95s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 0.91s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.82s | |
| ✅ REPOSITORY | trivy | yes | no | no | 7.52s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.22s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 2.22s | |
| lychee | 80 | 1 | 0 | 11.88s | ||
| ✅ YAML | prettier | 28 | 0 | 0 | 0 | 1.0s |
| ✅ YAML | v8r | 28 | 0 | 0 | 7.44s | |
| ✅ YAML | yamllint | 28 | 0 | 0 | 1.0s |
Detailed Issues
⚠️ SPELL / lychee - 1 error
[IGNORED] docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a)
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
📝 Summary
---------------------
🔍 Total..........126
✅ Successful.....123
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1
Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.3.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
.github/actions/update-vscode-extensions/update-vscode-extensions.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Update mull-19 Co-authored-by: philips-software-forest-releaser[bot] <80338643+philips-software-forest-releaser[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Pull Request Report (#1114)Static measures
Time related measures
Status check related measures
|




🚀 Hey, I have created a Pull Request
Description of changes
This pull request introduces several improvements to the automation of updating VS Code extensions and APT dependencies in the development container setup. The changes enhance robustness, improve release note generation, and streamline the process for both scheduled and pull request-based updates. Notably, the VS Code extension update logic now more reliably fetches release notes, outputs a summary file, and the workflow better supports PR previews and manual testing.
Key changes:
VS Code Extension Update Action Improvements
update-vscode-extensions.sh) now fetches GitHub release notes based on the publish date of the current extension version, making it more robust to different versioning schemes and ensuring only relevant release notes are included. It also prevents GitHub backlinks and at-mentions in the notes.markdown-summary-file), instead of embedding the summary directly in workflow outputs. [1] [2]Workflow Enhancements
Robustness and Usability
These changes collectively make the dependency update process more reliable, informative, and user-friendly for both maintainers and reviewers.
✔️ Checklist