Fix return type for 5 misc functions: bool -> true#5357
Open
lacatoire wants to merge 2 commits intophp:masterfrom
Open
Fix return type for 5 misc functions: bool -> true#5357lacatoire wants to merge 2 commits intophp:masterfrom
lacatoire wants to merge 2 commits intophp:masterfrom
Conversation
These functions always return true (or throw on error): - finfo_close (fileinfo) - ftp_set_option (ftp) - libxml_set_external_entity_loader (libxml) - shm_detach (shmop) - array_multisort (standard)
Member
|
Don't you also need a changelog entry for this? |
ndossche
requested changes
Feb 7, 2026
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Take for example the libxml_set_external_entity_loader() function: the changelog says it changed in PHP 8.2 but that's not true. You may have the same issue on other places too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix return type from
booltotruefor 5 functions from various extensions that always returntrue(or throw on error):finfo_close(fileinfo)ftp_set_option(ftp)libxml_set_external_entity_loader(libxml)shm_detach(shmop)array_multisort(standard)Reference