FAQ: Mention named arguments and discourage manual escaping#5377
Open
Dustaboy3 wants to merge 2 commits intophp:masterfrom
Open
FAQ: Mention named arguments and discourage manual escaping#5377Dustaboy3 wants to merge 2 commits intophp:masterfrom
Dustaboy3 wants to merge 2 commits intophp:masterfrom
Conversation
Updates the FAQ: - Mentions named arguments in the parameter order entry. - Adds a note discouraging manual escaping in the addslashes entry, recommending prepared statements and parameter binding instead.
Contributor
|
LGTM! @Dustaboy3 Both long-standing TODO comments resolved with accurate content. Named arguments confirmed in Minor style nit: "which makes the parameter order less important when it improves readability" could be clearer as "making parameter order less of a concern". |
Reworded a sentence to improve clarity, making parameter order less of a concern.
Author
|
Thanks for the review! Good catch - updated the wording |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the FAQ: