Skip to content

fix(extgen): use fast ZPP #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexandre-daubois wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −6
Open

fix(extgen): use fast ZPP #2088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions internal/extgen/paramparser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,7 @@ func (pp *ParameterParser) getDefaultValue(param phpParameter, fallback string)

func (pp *ParameterParser) generateParamParsing(params []phpParameter, requiredCount int) string {
if len(params) == 0 {
return ` if (zend_parse_parameters_none() == FAILURE) {
RETURN_THROWS();
}`
return ` ZEND_PARSE_PARAMETERS_NONE();`
}

var builder strings.Builder
Expand Down
4 changes: 1 addition & 3 deletions internal/extgen/paramparser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,7 @@ func TestParameterParser_GenerateParamParsing(t *testing.T) {
name: "no parameters",
params: []phpParameter{},
requiredCount: 0,
expected: ` if (zend_parse_parameters_none() == FAILURE) {
RETURN_THROWS();
}`,
expected: ` ZEND_PARSE_PARAMETERS_NONE();`,
},
{
name: "single required string parameter",
Expand Down