fix: Allow variadic syntax in PHPDoc parameter annotation in gen_stub.php
#20342
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2025
TimWolla
reviewed
Oct 30, 2025
mitelg
force-pushed
the
fix/gen_stub-variadic-parameter-phpdoc
branch
from
653ca50 to
4e5214b
Compare
iluuu1994
approved these changes
Nov 12, 2025
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Looks correct to me. @kocsismate Can you verify?
kocsismate
approved these changes
Nov 13, 2025
Author
|
hey @TimWolla @iluuu1994 @kocsismate first thanks for your reviews! it seems we are ready to go, right? Or do you need something else from my side? Thanks again, and have a nice day 👋 |
Member
|
@mitelg I removed some unnecessary changes (the named capture group was the incorrct one), and will merge as soon as CI is green. |
Not that it matters, we just want no unrelated changes.
Member
|
Ping @iluuu1994 :) I've just noticed that merge was forgotten. I can do it if you don't have time for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
gen_stub.phpscript to allow PHPDoc parameter annotations to have proper variadic syntax.The according regExes are adjusted to allow additional
...right in front of the parameter name. See linked issue for more information.Closes #20277