make preserve_none check lto compatible, fix #20806 #20809
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this will be copied on the call frame, a refcounted copy is not necessary.
This makes the code more compact, and less weird: the stub doesn't indicate that this function can return NULL.
If we use signed integers (which fit the unsigned chars), then we can avoid the extra checks. Also move an exception check to the proper place.
* PHP-8.5: Fix phpGH-20435: SensitiveParameter doesn't work for named argument passing to variadic parameter Fix phpGH-20442: Phar does not respect case-insensitiveness of __halt_compiler() when reading stub
* PHP-8.5: memory_limit is not always limited by max_memory_limit
* PHP-8.5: Commit the actual fix for phpGH-17951
* PHP-8.5: Fix nightly failure due to OnChangeMemoryLimit changes (php#20450)
* PHP-8.5: [ci skip] Fix NEWS ordering
* PHP-8.5: Fix memory leak when edge case is hit when registering xpath callback
* PHP-8.5: uri: Update to uriparser-0.9.9-59-gc3b4956 (php#20437)
* PHP-8.5: ext/uri: Fix the distinction between an empty and a missing query/fragment for WHATWG URLs (php#20208)
* PHP-8.5: Fix phpGH-20439: xml_set_default_handler() does not properly handle special characters in attributes when passing data to callback (php#20453)
* PHP-8.5: PHP-8.3 is now for PHP-8.3.31
This adds so_keepalive, tcp_keepidle, tcp_keepintvl and tcp_keepcnt stream socket context options that are used to set their upper case C macro variants by setsockopt function. The test requires sockets extension and just tests that the values are being set. This is because a real test would be slow and difficult to show that those options really work due to how they work internally. Closes phpGH-20381
* PHP-8.5: PHP 8.4 is now for PHP 8.4.18-dev
This is consistent with http and ssl wrappers where int values are converted in this way.
* PHP-8.5: PHP-8.5 is now for PHP 8.5.3-dev
henderkes
requested review from
DanielEScherzer,
Girgias,
NattyNarwhal,
SakiTakamachi,
TimWolla,
adoy,
alexdowad,
arnaud-lb,
bukka,
derickr,
devnexen,
dstogov,
kamil-tekiela,
kocsismate,
ndossche,
youkidearitai and
zeriyoshi
as code owners
Contributor
Author
|
Argh, that was a bad idea. Closing and reopening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit: also prints the result of it now, which was missing previously
closes #20806