Skip to content

Conversation

@saundefined
Copy link
Member

@saundefined saundefined commented Sep 22, 2024

Let's start preparing for the release.

  • Update logo ( @pronskiy )
  • Finish the English version
  • Put messages in lang-files
  • Add links to Documentation
  • Waiting for the release of PHP 8.4 🎉

Any help is welcome, especially from RFC authors :)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2024

🚀 Preview for commit 9fc3eff can be found at https://web-php-pr-1079.preview.thephp.foundation

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2024

🚀 Regression report for commit 9fc3eff is at https://web-php-regression-report-pr-1079.preview.thephp.foundation

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A big feature of this release is also the dedicated PDO Driver subclasses, IMHO.

@ndossche
Copy link
Member

ndossche commented Oct 3, 2024

The rendering of the property hooks snippet is a bit ugly, screen resolution is 1920x1080
Screenshot from 2024-10-03 21-28-52

Copy link
Contributor

@jorgsowa jorgsowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@ndossche ndossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this for DOM?

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have some suggestions for the #[\Deprecated] example to make it self-contained.

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also removing the lazy objects from the title, replacing it with the new DOM API which sounds sufficiently shiny.

@TimWolla
Copy link
Member

@saundefined It appears the release page on https://web-php-pr-1079.preview.thephp.foundation/releases/8.4/en.php is broken. Did the deploy fail? I'm not seeing any syntax errors in the last two commits.

@saundefined
Copy link
Member Author

Did the deploy fail?

I think so, thanks for pointing that out!
I re-run the workflow, and it deployed correctly.

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a chat with a co-worker about the release page and he disliked the Property Hook example, because:

  1. It uses western naming assumptions.
  2. It only shows virtual properties, which as per the RFC is not the main use case of the property hooks. The main use case is not writing methods because they “might” be used.

To fix these issues, we came up with the suggested examples. By using a technical identifier, we do not run into the “Falsehoods Programmers Believe About Names” issue and by leaving languageCode a regular property we showcase all three main types of hook usage (“no hook”, “set-only hook”, and “virtual property”).

@saundefined
Copy link
Member Author

@TimWolla thanks a lot! ❤️

Copy link
Contributor

@theodorejb theodorejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These methods don't exist in the property hooks version.

Copy link
Member

@ndossche ndossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on Tim's feedback:

Copy link
Contributor

@theodorejb theodorejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more suggestion: I think the Asymmetric Visibility example should have a line which reads the property, so it's clearer that this still works.

@marcosmarcolin
Copy link
Contributor

@saundefined I would like to contribute with pt_BR for the release. Should I include it in this MR, or make a separate one?

@saundefined
Copy link
Member Author

@marcosmarcolin I think it's better in this one, to merge all the changes at once.
But keep in mind that the text of the English version is still subject to change

Copy link
Contributor

@jorgsowa jorgsowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three messages are not displayed in the page.

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some missing return types in the examples.

Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Copy link
Contributor

@jorgsowa jorgsowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added points about:

  • new JIT implementation
  • function grapheme_str_split().

saundefined and others added 2 commits November 19, 2024 01:27
Co-authored-by: Jorg Adam Sowa <jorg.sowa@gmail.com>
@saundefined
Copy link
Member Author

Final preparations before merging,
I guess I'll merge it a little later today.

All references to PHP 8.4 from the main page and header have been reverted,
the page will only be accessible via a direct link.

A separate PR will be prepared later today as well.

@saundefined saundefined changed the title PHP 8.4 release page Preparing PHP 8.4 announcement page Nov 19, 2024
Copy link
Contributor

@bkosun bkosun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove redundant details as all changes are related to PHP 8.4

Co-authored-by: Borislav Kosun <kosun.b@yandex.com>
@saundefined saundefined merged commit 039acc1 into php:master Nov 19, 2024
3 checks passed
@saundefined saundefined deleted the php84 branch November 19, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.