Change asymmetric visibility example to show how it simplifies code #1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodorejb
force-pushed
the
asymmetric-visibility-example
branch
from
b88db30 to
6abf161
Compare
Contributor
|
🚀 Preview for commit 420a34a can be found at https://web-php-pr-1135.preview.thephp.foundation |
Contributor
|
🚀 Regression report for commit 420a34a is at https://web-php-regression-report-pr-1135.preview.thephp.foundation |
Member
|
LGTM, thanks! @TimWolla can you also take a look? |
TimWolla
reviewed
Nov 20, 2024
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
Example is clearly an improvement.
The previous example wasn't very helpful, since it only showed invalid code that will error (and could just as easily be replaced with a readonly property).
theodorejb
force-pushed
the
asymmetric-visibility-example
branch
from
6abf161 to
ff4b85e
Compare
saundefined
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous example wasn't very helpful, since it only showed invalid code that will error (and could just as easily be replaced with a
readonlyproperty).