Skip to content

fix: adds trailing space #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DanielEScherzer merged 1 commit into from
Aug 26, 2025
Merged

fix: adds trailing space #1357

DanielEScherzer merged 1 commit into from
Aug 26, 2025

Conversation

@ismaelmartinezc
Copy link
Contributor

@ismaelmartinezc ismaelmartinezc commented Aug 26, 2025 •
edited
Loading

I added a trailing space to fix this:
image

Please take a look at: https://www.php.net/releases/index.php

DanielEScherzer
DanielEScherzer approved these changes Aug 26, 2025
View reviewed changes
Copy link
Member

@DanielEScherzer DanielEScherzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@DanielEScherzer DanielEScherzer merged commit 3c99682 into php:master Aug 26, 2025
3 checks passed
@ismaelmartinezc ismaelmartinezc deleted the fix-missing-trailing-space branch August 27, 2025 17:37
marcosmarcolin pushed a commit to marcosmarcolin/web-php that referenced this pull request Oct 9, 2025
@ismaelmartinezc @marcosmarcolin
Releases: add missing space to discontinued major versions (php#1357)
7ea6d49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielEScherzer DanielEScherzer DanielEScherzer approved these changes

@saundefined saundefined Awaiting requested review from saundefined saundefined is a code owner

@sy-records sy-records Awaiting requested review from sy-records sy-records is a code owner

@sgolemon sgolemon Awaiting requested review from sgolemon sgolemon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ismaelmartinezc @DanielEScherzer