Skip to content

Update meta tags to use dynamic title #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sy-records wants to merge 1 commit into from
Closed

Update meta tags to use dynamic title #1370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions include/layout.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,21 +437,21 @@ function site_header(string $title = 'Hypertext Preprocessor', array $config = [
"cache" => false,
"headsup" => "",
'meta_tags' => <<<META
<meta name="Description" content="{$meta_description}" />
<meta name="description" content="{$meta_description}" />

<meta name="twitter:card" content="summary_large_image" />
<meta name="twitter:site" content="@official_php" />
<meta name="twitter:title" content="PHP: Hypertext Preprocessor" />
<meta name="twitter:title" content="PHP: {$title}" />
<meta name="twitter:description" content="{$meta_description}" />
<meta name="twitter:creator" content="@official_php" />
<meta name="twitter:image:src" content="{$meta_image_path}" />

<meta itemprop="name" content="PHP: Hypertext Preprocessor" />
<meta itemprop="description" content="$meta_description" />
<meta itemprop="name" content="PHP: {$title}" />
<meta itemprop="description" content="{$meta_description}" />
<meta itemprop="image" content="{$meta_image_path}" />

<meta property="og:image" content="{$meta_image_path}" />
<meta property="og:description" content="$meta_description" />
<meta property="og:description" content="{$meta_description}" />

<link href="https://fosstodon.org/@php" rel="me" />
META
Expand Down
2 changes: 1 addition & 1 deletion include/shared-manual.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ function manual_setup($setup): void {
"next" => $setup["next"],
"cache" => $lastmod,
];
site_header($setup["this"][1] . " - Manual ", $config);
site_header($setup["this"][1] . " - Manual", $config);

$languageChooser = manual_language_chooser($config['lang'], $config['thispage']);

Expand Down