Separate enum tests

Author: janedbal

tests/PHPStan/Reflection/Deprecation/DeprecationProviderTest.php

@@ -22,8 +22,8 @@ class DeprecationProviderTest extends PHPStanTestCase
 
 	public function testCustomDeprecations(): void
 	{
-		if (PHP_VERSION_ID < 80100) {
-			self::markTestSkipped('PHP 8.1+ is required to test enums.');
+		if (PHP_VERSION_ID < 80000) {
+			self::markTestSkipped('PHP 8.0+ is required as CustomDeprecationProvider uses unions.');
 		}
 
 		require __DIR__ . '/data/deprecations.php';
@@ -59,24 +59,6 @@ public function testCustomDeprecations(): void
 		$scopeForDoubleDeprecatedClassOnlyNativeMessage = $scopeFactory->create(ScopeContext::create('dummy.php')->enterClass($doubleDeprecatedClassOnlyPhpDocMessage));
 		$scopeForDoubleDeprecatedClassOnlyCustomMessage = $scopeFactory->create(ScopeContext::create('dummy.php')->enterClass($doubleDeprecatedClassOnlyAttributeMessage));
 
-		// enum cases
-		$myEnum = $reflectionProvider->getClass(MyDeprecatedEnum::class);
-
-		self::assertTrue($myEnum->isDeprecated());
-		self::assertNull($myEnum->getDeprecatedDescription());
-
-		self::assertTrue($myEnum->getEnumCase('CustomDeprecated')->isDeprecated()->yes());
-		self::assertSame('custom', $myEnum->getEnumCase('CustomDeprecated')->getDeprecatedDescription());
-
-		self::assertTrue($myEnum->getEnumCase('NativeDeprecated')->isDeprecated()->yes());
-		self::assertSame('native', $myEnum->getEnumCase('NativeDeprecated')->getDeprecatedDescription());
-
-		self::assertTrue($myEnum->getEnumCase('PhpDocDeprecated')->isDeprecated()->yes());
-		self::assertNull($myEnum->getEnumCase('PhpDocDeprecated')->getDeprecatedDescription()); // this should not be null
-
-		self::assertFalse($myEnum->getEnumCase('NotDeprecated')->isDeprecated()->yes());
-		self::assertNull($myEnum->getEnumCase('NotDeprecated')->getDeprecatedDescription());
-
 		// class
 		self::assertFalse($notDeprecatedClass->isDeprecated());
 		self::assertNull($notDeprecatedClass->getDeprecatedDescription());
@@ -203,6 +185,34 @@ public function testCustomDeprecations(): void
 		self::assertSame('attribute', $doubleDeprecatedFunctionOnlyAttributeMessage->getDeprecatedDescription());
 	}
 
+	public function testCustomDeprecationsOfEnumCases(): void
+	{
+		if (PHP_VERSION_ID < 80100) {
+			self::markTestSkipped('PHP 8.1+ is required to test enums.');
+		}
+
+		require __DIR__ . '/data/deprecations-enums.php';
+
+		$reflectionProvider = self::createReflectionProvider();
+
+		$myEnum = $reflectionProvider->getClass(MyDeprecatedEnum::class);
+
+		self::assertTrue($myEnum->isDeprecated());
+		self::assertNull($myEnum->getDeprecatedDescription());
+
+		self::assertTrue($myEnum->getEnumCase('CustomDeprecated')->isDeprecated()->yes());
+		self::assertSame('custom', $myEnum->getEnumCase('CustomDeprecated')->getDeprecatedDescription());
+
+		self::assertTrue($myEnum->getEnumCase('NativeDeprecated')->isDeprecated()->yes());
+		self::assertSame('native', $myEnum->getEnumCase('NativeDeprecated')->getDeprecatedDescription());
+
+		self::assertTrue($myEnum->getEnumCase('PhpDocDeprecated')->isDeprecated()->yes());
+		self::assertNull($myEnum->getEnumCase('PhpDocDeprecated')->getDeprecatedDescription()); // this should not be null
+
+		self::assertFalse($myEnum->getEnumCase('NotDeprecated')->isDeprecated()->yes());
+		self::assertNull($myEnum->getEnumCase('NotDeprecated')->getDeprecatedDescription());
+	}
+
 	public static function getAdditionalConfigFiles(): array
 	{
 		return [

tests/PHPStan/Reflection/Deprecation/data/CustomDeprecated.php

@@ -0,0 +1,15 @@
+<?php // lint >= 8.1
+
+namespace CustomDeprecations;
+
+#[\Attribute(\Attribute::TARGET_ALL)]
+class CustomDeprecated {
+
+	public ?string $description;
+
+	public function __construct(
+		?string $description = null
+	) {
+		$this->description = $description;
+	}
+}

tests/PHPStan/Reflection/Deprecation/data/deprecations-enums.php

@@ -0,0 +1,33 @@
+<?php // lint >= 8.1
+
+namespace CustomDeprecations;
+
+#[\Attribute(\Attribute::TARGET_ALL)]
+class CustomDeprecated {
+
+	public ?string $description;
+
+	public function __construct(
+		?string $description = null
+	) {
+		$this->description = $description;
+	}
+}
+
+#[CustomDeprecated]
+enum MyDeprecatedEnum: string
+{
+	#[CustomDeprecated('custom')]
+	case CustomDeprecated = '1';
+
+	/**
+	 * @deprecated phpdoc
+	 */
+	case PhpDocDeprecated = '2';
+
+	#[\Deprecated('native')]
+	case NativeDeprecated = '3';
+
+	case NotDeprecated = '4';
+
+}

tests/PHPStan/Reflection/Deprecation/data/deprecations.php

@@ -2,18 +2,6 @@
 
 namespace CustomDeprecations;
 
-#[\Attribute(\Attribute::TARGET_ALL)]
-class CustomDeprecated {
-
-	public ?string $description;
-
-	public function __construct(
-		?string $description = null
-	) {
-		$this->description = $description;
-	}
-}
-
 class NotDeprecatedClass
 {
 	const FOO = 'foo';
@@ -161,22 +149,3 @@ function doubleDeprecatedFunctionOnlyAttributeMessage() {}
 /** @deprecated phpdoc */
 #[CustomDeprecated()]
 function doubleDeprecatedFunctionOnlyPhpDocMessage() {}
-
-
-#[CustomDeprecated]
-enum MyDeprecatedEnum: string
-{
-	#[CustomDeprecated('custom')]
-	case CustomDeprecated = '1';
-
-	/**
-	 * @deprecated phpdoc
-	 */
-	case PhpDocDeprecated = '2';
-
-	#[\Deprecated('native')]
-	case NativeDeprecated = '3';
-
-	case NotDeprecated = '4';
-
-}