test constant strings

Author: staabm

tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php

@@ -807,25 +807,33 @@ public function testBug11946(): void
 				'Offset -1 does not exist on string.',
 				25,
 			],
+			[
+				"Offset 10 does not exist on 'hi'.",
+				29,
+			],
 			[
 				'Offset int<-5, 5> might not exist on string.',
-				45,
+				49,
 			],
 			[
 				'Offset int<-5, 5> might not exist on numeric-string.',
-				46,
+				50,
 			],
 			[
 				'Offset int<-5, 5> might not exist on non-empty-string.',
-				47,
+				51,
 			],
 			[
 				'Offset int<-5, 5> might not exist on non-falsy-string.',
-				48,
+				52,
 			],
 			[
 				'Offset int<-5, 5> might not exist on string.',
-				49,
+				53,
+			],
+			[
+				"Offset int<-5, 5> might not exist on 'hi'.",
+				56,
 			],
 		]);
 	}

tests/PHPStan/Rules/Arrays/data/bug-11946.php

@@ -23,6 +23,10 @@ public function nonExistentStringOffset(
 		echo $nonEmpty[-1];
 		echo $nonFalsy[-1];
 		echo $lowerCase[-1];
+
+		$s = 'hi';
+		echo $s[1];
+		echo $s[10];
 	}
 
 	/**
@@ -47,5 +51,8 @@ public function maybeNonExistentStringOffset(
 		echo $nonEmpty[$maybeWrong];
 		echo $nonFalsy[$maybeWrong];
 		echo $lowerCase[$maybeWrong];
+
+		$s = 'hi';
+		echo $s[$maybeWrong];
 	}
 }