Attribute #[AutowiredService] for slimmer config.neon
#4016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
force-pushed
the
autowired-service-attribute
branch
3 times, most recently
from
1bf7631 to
854fe0d
Compare
ondrejmirtes
force-pushed
the
autowired-service-attribute
branch
2 times, most recently
from
c8fcb8d to
ec71f00
Compare
so that it can downgrade code before installin g phpstan-src dependencies and running attribute collector plugin
ondrejmirtes
force-pushed
the
autowired-service-attribute
branch
from
ec71f00 to
059b856
Compare
Collaborator
|
This pull request has been marked as ready for review. |
staabm
reviewed
May 25, 2025
Comment on lines
+75
to
+77
| "cweagans/composer-patches": true, | ||
| "ondrejmirtes/composer-attribute-collector": true, | ||
| "vaimo/composer-patches": true |
Contributor
There was a problem hiding this comment.
why do we need 2 composer-patches packages?
Member
Author
There was a problem hiding this comment.
We don't, it's probably a mistake and one of those lines can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.