Use Type->isInteger() over $dimType instanceof ConstantIntegerType
#4161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This pull request has been marked as ready for review. |
staabm
commented
Jul 26, 2025
| new NullType(), | ||
| ]; | ||
| if ($dimType instanceof ConstantIntegerType) { | ||
| if ($dimType->isInteger()->yes()) { |
Contributor
Author
There was a problem hiding this comment.
$dimType instance ConstantIntegerType is already narrowed in the outer if
ondrejmirtes
requested changes
Jul 26, 2025
Member
ondrejmirtes
left a comment
ondrejmirtes
left a comment
There was a problem hiding this comment.
Hey, this change isn't really valuable. With the original code it's obvious what's going on. We just want the if to be executed only when the left part of BooleanOr is true.
It'd also be nice to change the line with $dimType instanceof ConstantIntegerType || $dimType instanceof ConstantStringType. I understand that it might be difficult, in that case feel free to close the PR.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.