Skip to content

Update PHPStan packages #4621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 5 commits into from
Dec 9, 2025
+39 −14
Merged

Update PHPStan packages #4621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e127bef
Update PHPStan packages to v2.0.6
renovate[bot] Oct 20, 2025
7b71575
fix
staabm Dec 9, 2025
d3f3e2c
fix php7 error
staabm Dec 9, 2025
2730669
ignore substr() errors
staabm Dec 9, 2025
5c90f24
move ignores
staabm Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions build/baseline-pre-8.0.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,3 +113,18 @@ parameters:
identifier: parameter.phpDocType
count: 1
path: ../src/Reflection/ClassReflectionFactory.php

-
message: '#^Parameter \#3 of function sprintf is expected to be string by placeholder \#2 \("%%s"\), string\|false given\.$#'
count: 1
path: ../src/Cache/FileCacheStorage.php

-
message: '#^Parameter \#3 of function sprintf is expected to be string by placeholder \#2 \("%%s"\), string\|false given\.$#'
count: 1
path: ../src/Rules/Cast/InvalidCastRule.php

-
message: '#^Parameter \#2 of function sprintf is expected to be string by placeholder \#1 \("%%s"\), string\|false given\.$#'
count: 1
path: ../src/Rules/ClassForbiddenNameCheck.php
Comment on lines +117 to +130
Copy link
Contributor Author

@staabm staabm Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to make the type inference more useful, but in the end everything I did which fixed php 7.x errors, created new php8 errors.

therefore added php7.x only ignores and called it a day

26 changes: 13 additions & 13 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions stubs/ReflectionClass.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ class ReflectionClass
*/
public function getName() : string;

/**
* @return non-empty-string
*/
public function getShortName() : string;

/**
* @param mixed ...$args
*
Expand Down
5 changes: 5 additions & 0 deletions stubs/ReflectionClassWithLazyObjects.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ class ReflectionClass
*/
public function getName() : string;

/**
* @return non-empty-string
*/
public function getShortName() : string;

/**
* @param mixed ...$args
*
Expand Down
2 changes: 1 addition & 1 deletion tests/PHPStan/Analyser/NodeScopeResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ public function testFile(string $file): void
$actual = $args[3];

if ($expected !== $actual) {
$failures[] = sprintf("Line %d:\nExpected: %s\nActual: %s\n", $args[4], $expected, $actual);
$failures[] = sprintf("Line %d:\nExpected: %s\nActual: %s\n", $args[4], (string) $expected, $actual);
}
} elseif ($args[0] === 'variableCertainty') {
$file = $args[1];
Expand Down
Loading