Better pagination for large datasets#468
Better pagination for large datasets#468sinisaos wants to merge 4 commits intopiccolo-orm:masterfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
==========================================
+ Coverage 93.42% 94.04% +0.62%
==========================================
Files 5 5
Lines 365 403 +38
==========================================
+ Hits 341 379 +38
Misses 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| <p id="result_count"> | ||
| {{ $t("Showing") }} {{ rows.length }} | ||
| {{ $t("of") }} | ||
| {{ rowCount }} | ||
| {{ $t("result(s)") }} | ||
| </p> | ||
|
|
There was a problem hiding this comment.
I'd keep this - it is sometimes useful to see the number of results.
| "For timestamps which are timezone aware, they will be displayed in this timezone by default.": "For timestamps which are timezone aware, they will be displayed in this timezone by default.", | ||
| "Form submitted": "Form submitted", | ||
| "Forms": "Forms", | ||
| "Go to page": "Go to page", |
There was a problem hiding this comment.
I am not sure how it works in this project, but in my opinion translations shouldn't be removed.
There was a problem hiding this comment.
I don't think we need it anymore because in this PR we don't use HTML select for pagination.
|
This PR has been marked as stale because it has been open for 30 days with no activity. Are there any blockers, or should this be closed? |
4 participants
Related to #463