drop Python 3.9 and adds support for Python 3.14#317
drop Python 3.9 and adds support for Python 3.14#317dantownsend merged 3 commits intopiccolo-orm:masterfrom
Conversation
|
@dantownsend I don't know why ci failed. Locally everything works on both |
|
@sinisaos I'm on my phone, so can't check properly but maybe the exception name changed or something, and we're not catching it. |
…because everything works locally
| status_code=422, | ||
| ) | ||
| except ForeignKeyViolationError as exception: | ||
| except (ForeignKeyViolationError, RestrictViolationError) as exception: |
There was a problem hiding this comment.
I added RestrictViolationError alongside ForeignKeyViolationError and the tests passed. Can you check if that is good enough.
There was a problem hiding this comment.
I wonder if you have a different version of asyncpg locally?
There was a problem hiding this comment.
No. It's a fresh virtualenv with Piccolo API requirements. It passed locally even without this change, but in ci it fails and throws RestrictViolationError.
There was a problem hiding this comment.
OK, I think this change is fine. It might be CI is running a slightly different Postgres version.
|
Looks great, thanks 👍 |
2 participants
Same as in the main Piccolo repository.