-
-
Notifications
You must be signed in to change notification settings - Fork 10
chore: homogenize CI workflow with Vue stack #3123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,31 +7,27 @@ on: | |
| branches: [master] | ||
|
|
||
| jobs: | ||
| build: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [22.x, 24.x] | ||
| mongodb-version: ['7.0'] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| - name: Use Node.js LTS | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| node-version: lts/* | ||
| cache: 'npm' | ||
| - name: Start Mongo ${{ matrix.mongodb-version }} | ||
| - name: Start MongoDB LTS | ||
| uses: supercharge/mongodb-github-action@1.12.1 | ||
| with: | ||
| mongodb-version: ${{ matrix.mongodb-version }} | ||
| mongodb-version: '7.0' | ||
|
Comment on lines
+15
to
+23
|
||
| - name: Run tests | ||
| run: | | ||
| npm i | ||
| npm install | ||
| npm run lint | ||
| npm run test:coverage | ||
| - name: Upload coverage reports to Codecov | ||
| uses: codecov/codecov-action@v5 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| slug: pierreb-devkit/Node | ||
|
Comment on lines
29
to
+33
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow no longer runs a Node.js matrix: the
strategy.matrixblock was removed andactions/setup-nodeis pinned tolts/*, so CI will only test a single Node version (whatever is current LTS) rather than both22.xand24.xas described in the PR. Re-introduce the matrix and setnode-versionfrommatrix.node-versionso both versions are exercised.