Builder host configuration #210
Draft
+45
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved host setting logic outside if/else block in Pinecone.Builder.build() - Host is now set on both config and apiClient regardless of whether customOkHttpClient is provided - Added tests to verify: - Host is respected with customOkHttpClient - Host works without customOkHttpClient - CustomOkHttpClient works without host - All new tests pass successfully Co-authored-by: jhamon <jhamon@pinecone.io>
|
Cursor Agent can help with this pull request. Just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the
hostparameter was ignored whencustomOkHttpClientwas also provided inPinecone.Builder.The host handling logic was previously within the
elseblock for defaultOkHttpClientcreation, causing the specifiedhostto be bypassed when acustomOkHttpClientwas provided. This PR moves the host setting logic outside this conditional block, ensuring it is always applied to theApiClientandconfigregardless of whether a custom client is used.Linear Issue: SDK-55