Skip to content

Conversation

@jhamon
Copy link
Contributor

@jhamon jhamon commented Jan 14, 2026

Remove SLF4J dependency from IndexCleanupUtility to fix NoClassDefFoundError in CI.

The IndexCleanupUtility was crashing in the CI workflow because the shadowJar relocates org.slf4j to io.pinecone.shadow.org.slf4j. However, the utility was still importing and trying to use the unshaded org.slf4j.LoggerFactory, which was not available on the runtime classpath provided by the workflow. This change makes the utility independent of SLF4J by using a simple System.err based logger. New unit tests for CLI argument parsing were also added to prevent regression.


Open in Cursor Open in Web


Note

Resolves runtime logging dependency issues and hardens CLI handling for the cleanup utility.

  • Replaces SLF4J with lightweight System.err-based logging (logInfo/logWarn/logError), removing external logger imports and calls
  • Extracts and validates CLI parsing via parseArgs with clear errors for missing/invalid/negative values; logs unknown args
  • Updates main to use ParsedArgs and new logging helpers; improves error reporting and summary output
  • Adds unit tests covering argument parsing and cleanup paths (dry-run, terminating resources, null/empty lists, successful deletions)

Written by Cursor Bugbot for commit 80624cf. This will update automatically on new commits. Configure here.

cursoragent and others added 2 commits January 14, 2026 21:14
Co-authored-by: jhamon <jhamon@pinecone.io>
Co-authored-by: jhamon <jhamon@pinecone.io>
@cursor
Copy link

cursor bot commented Jan 14, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@jhamon jhamon marked this pull request as ready for review January 14, 2026 21:16
@jhamon jhamon changed the title Client build failure fix: client build failure in test cleanup utility Jan 14, 2026
@jhamon jhamon merged commit f259f23 into main Jan 14, 2026
10 of 12 checks passed
@jhamon jhamon deleted the cursor/client-build-failure-aee1 branch January 14, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants