Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #21846

  • Query optimization with partition pruning
  • Performance comparison: Non-Partitioned vs Local Index vs Global Index
  • Data cleanup efficiency: TTL vs DROP PARTITION
  • Partition drop performance: Local Index vs Global Index
  • Strategies to mitigate write hotspot issues with hash/key partitioning
  • Partition management challenges and best practices
    • Avoiding read/write hotspots on new partitions
    • Using PRE_SPLIT_REGIONS, SHARD_ROW_ID_BITS, and region splitting
  • Converting between partitioned and non-partitioned tables
    • Batch DML, Pipeline DML, IMPORT INTO, and Online DDL efficiency comparison

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added area/best-practices Adds or updates TiDB best practices. lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jan 19, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new, detailed guide on best practices for leveraging TiDB partitioned tables. The guide aims to equip users with the knowledge to optimize query performance, streamline data management and deletion processes, effectively mitigate common hotspot issues, and understand the performance characteristics of various table conversion methods. It provides practical advice and test results to aid in designing and tuning partitioned tables for efficiency and scalability.

Highlights

  • New Best Practices Guide: A comprehensive guide on 'Best Practices for Using TiDB Partitioned Tables' has been added, covering various aspects of partitioned table management and optimization.
  • Query Performance Optimization: The guide details partition pruning techniques and provides a performance comparison of queries on non-partitioned tables versus partitioned tables with local and global indexes, offering recommendations for optimal index usage.
  • Efficient Data Cleanup: It compares the efficiency of TTL (Time to Live) and DROP PARTITION for bulk data deletion, highlighting the significant performance advantages of DROP PARTITION for large datasets, especially with local indexes.
  • Hotspot Mitigation Strategies: Strategies for mitigating read and write hotspots are discussed, including the use of Hash/Key partitioning, SHARD_ROW_ID_BITS, PRE_SPLIT_REGIONS, and the merge_option=deny attribute for Range partitions.
  • Table Conversion Methods: The document evaluates the performance of different methods for converting between partitioned and non-partitioned tables, such as Pipelined DML, IMPORT INTO, and Online DDL, providing insights into their respective efficiencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a comprehensive guide on best practices for using partitioned tables in TiDB. The new documentation covers query optimization, data cleanup, hotspot mitigation, and partition management. My review focuses on improving grammar, clarity, and formatting consistency to enhance readability, following the repository's style guide. I've suggested corrections for verb tense, rephrasing for clarity, and using proper heading hierarchy for better document structure.

@hfxsd
Copy link
Collaborator

hfxsd commented Jan 19, 2026

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 19, 2026
@ti-chi-bot ti-chi-bot bot merged commit 78e848c into pingcap:release-8.5 Jan 19, 2026
9 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-21846-to-release-8.5 branch January 19, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/best-practices Adds or updates TiDB best practices. lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants