-
Notifications
You must be signed in to change notification settings - Fork 34
Allowing xtol and ftol stopping criteria in OptimisationController #1508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5fe02a3 to
6105472
Compare
|
@martinjrobins @chonlei @mirams can you have a look and see if this makes sense, before I add tests? |
|
Fine, we can just go with long names
|
Going to do this next week, merge it in, and do a new release that's compatible with latest numpy #1712 unless anyone has strong objections @mirams @martinjrobins @chonlei ? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1508 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 97 97
Lines 9704 9741 +37
=========================================
+ Hits 9704 9741 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mirams @martinjrobins @chonlei last chance to object to these names and name changes! If I don't hear anything I'll merge this tomorrow evening |
|
Some alternatives suggested here: #1678 (comment) General vibe there: use |
Closes #1502
set_max_unchanged_iterations(1, ftol)set_max_unmoved_iterations(1, xtol)