Skip to content

Upgrade Go to latest minor releases #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddelnano merged 3 commits into from
Aug 11, 2025
Merged

Upgrade Go to latest minor releases #2256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d9d709
Upgrade Go to latest minor releases
ddelnano Aug 8, 2025
dd44e81
Update docker images with new go version
ddelnano Aug 8, 2025
1615f61
Fix unit tests
ddelnano Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ pl_go_overrides()

go_download_sdk(
name = "go_sdk",
version = "1.24.4",
version = "1.24.6",
)

go_rules_dependencies()
Expand Down Expand Up @@ -212,7 +212,7 @@ gazelle_dependencies(go_sdk = "go_sdk")

go_download_sdk(
name = "go_sdk_1_23",
version = "1.23.10",
version = "1.23.12",
)

# The go_sdk_boringcrypto SDK is used for testing boringcrypto specific functionality (TLS tracing).
Expand All @@ -225,7 +225,7 @@ go_download_sdk(
go_download_sdk(
name = "go_sdk_boringcrypto",
experiments = ["boringcrypto"],
version = "1.23.9",
version = "1.23.11",
)

pip_parse(
Expand Down
2 changes: 1 addition & 1 deletion bazel/pl_build_system.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library", "cc_test")
load("@rules_python//python:defs.bzl", "py_test")
load("//bazel:toolchain_transitions.bzl", "qemu_interactive_runner")

pl_boringcrypto_go_sdk = ["1.23.9"]
pl_boringcrypto_go_sdk = ["1.23.11"]
pl_go_test_versions = ["1.18", "1.19", "1.20", "1.21", "1.22"]
pl_supported_go_sdk_versions = ["1.23", "1.24"]

Expand Down
8 changes: 4 additions & 4 deletions docker.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
DOCKER_IMAGE_TAG=202507242250
LINTER_IMAGE_DIGEST=911f172364626f44efb61345517b5e7bb8c8ee8f065fcf3ba0a790ab1a88cdcb
DEV_IMAGE_DIGEST=08fc759c2b45078214be313335b8c3c23200aea54b9609e8c42fe367762e6c7c
DEV_IMAGE_WITH_EXTRAS_DIGEST=0ecefa696cfad238c432c2e213600263d00dda4ca4a427796f8fc16eb3d9bfc0
DOCKER_IMAGE_TAG=202508081946
LINTER_IMAGE_DIGEST=85a928e7607ef9c0c78f7aa421b04e328d5085bb1698bcf7eec1dcb6d609e3c8
DEV_IMAGE_DIGEST=4a116347d80d330e978d57552a9a49258fd615912cd8f94398a2281bb7e362eb
DEV_IMAGE_WITH_EXTRAS_DIGEST=5b60b6fa4a98265da41a8ec4ec363bf946fd1b5d7b977d46bd6c6d941e183816
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module px.dev/pixie

go 1.24.4
go 1.24.6

require (
cloud.google.com/go v0.81.0
Expand Down
2 changes: 1 addition & 1 deletion src/stirling/obj_tools/go_syms_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ TEST(ReadGoBuildInfoTest, BuildinfoEndianAgnostic) {
ASSERT_OK_AND_ASSIGN(std::unique_ptr<ElfReader> elf_reader, ElfReader::Create(kPath));
ASSERT_OK_AND_ASSIGN(auto pair, ReadGoBuildInfo(elf_reader.get()));
auto version = pair.first;
EXPECT_THAT(version, StrEq("1.24.4"));
EXPECT_THAT(version, StrEq("1.24.6"));
}

TEST(ReadGoBuildInfoTest, BuildinfoLittleEndian) {
Expand Down
8 changes: 4 additions & 4 deletions src/stirling/source_connectors/dynamic_tracer/dynamic_tracing/dwarvifier_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1820,28 +1820,28 @@ probes {
scalar_var {
name: "main__IntStruct_sym_addr1"
type: UINT64
constant: "5103904"
constant: "5104096"
}
}
vars {
scalar_var {
name: "runtime__errorString_sym_addr2"
type: UINT64
constant: "5104192"
constant: "5104384"
}
}
vars {
scalar_var {
name: "runtime__plainError_sym_addr3"
type: UINT64
constant: "5104224"
constant: "5104416"
}
}
vars {
scalar_var {
name: "internal___poll__errNetClosing_sym_addr4"
type: UINT64
constant: "5104256"
constant: "5104448"
}
}
vars {
Expand Down
4 changes: 2 additions & 2 deletions tools/chef/cookbooks/px_dev/attributes/linux.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
'648b599397548e4bb92429eec6391374c2cbb0edb835e3b3f03d4281c011f401'

default['golang']['download_path'] =
'https://go.dev/dl/go1.24.4.linux-amd64.tar.gz'
'https://go.dev/dl/go1.24.6.linux-amd64.tar.gz'
default['golang']['sha256'] =
'77e5da33bb72aeaef1ba4418b6fe511bc4d041873cbf82e5aa6318740df98717'
'bbca37cc395c974ffa4893ee35819ad23ebb27426df87af92e93a9ec66ef8712'

default['golangci-lint']['download_path'] =
'https://github.com/golangci/golangci-lint/releases/download/v2.0.2/golangci-lint-2.0.2-linux-amd64.tar.gz'
Expand Down
4 changes: 2 additions & 2 deletions tools/chef/cookbooks/px_dev/attributes/mac_os_x.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
'8d3709d957c7115610e764621569728be102d213fee15bc1d1aa9d465eb2c258'

default['golang']['download_path'] =
'https://go.dev/dl/go1.24.4.darwin-amd64.tar.gz'
'https://go.dev/dl/go1.24.6.darwin-amd64.tar.gz'
default['golang']['sha256'] =
'69bef555e114b4a2252452b6e7049afc31fbdf2d39790b669165e89525cd3f5c'
'4a8d7a32052f223e71faab424a69430455b27b3fff5f4e651f9d97c3e51a8746'

default['golangci-lint']['download_path'] =
'https://github.com/golangci/golangci-lint/releases/download/v2.0.2/golangci-lint-2.0.2-darwin-amd64.tar.gz'
Expand Down
Loading