Fix openssl bpf test failure introduced by python 3.12 upgrade #2292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelnano
commented
Dec 10, 2025
Comment on lines
+52
to
+54
| ssl_context = ssl.SSLContext(ssl.PROTOCOL_TLS_SERVER) | ||
| ssl_context.load_cert_chain(certfile='/etc/ssl/server.crt', keyfile="/etc/ssl/server.key") | ||
| httpd.socket = ssl_context.wrap_socket(httpd.socket, server_side=True) |
Member
Author
There was a problem hiding this comment.
Python 3.12 removed the previous APIs. The container was crashing with the following error:
Traceback (most recent call last):
File "/app/src/stirling/source_connectors/socket_tracer/testing/containers/ssl/python_min_310_https_server.binary.runfiles/px/src/stirling/source_connectors/socket_tracer/testing/containers/ssl/https_server.py", line 52, in <module>
httpd.socket = ssl.wrap_socket(httpd.socket,
^^^^^^^^^^^^^^^
AttributeError: module 'ssl' has no attribute 'wrap_socket'
2025-12-10 00:18:15,003 INFO sys.version_info(major=3, minor=12, micro=0, releaselevel='final', serial=0)
2025-12-10 00:18:15,003 INFO pid=1
Traceback (most recent call last):
File "/app/src/stirling/source_connectors/socket_tracer/testing/containers/ssl/python_min_310_https_server.binary.runfiles/px/src/stirling/source_connectors/socket_tracer/testing/containers/ssl/https_server.py", line 52, in <module>
httpd.socket = ssl.wrap_socket(httpd.socket,
^^^^^^^^^^^^^^^
AttributeError: module 'ssl' has no attribute 'wrap_socket'
oazizi000
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix openssl bpf test failure introduced by python 3.12 upgrade
The
OpenSSLTraceTest/5.ssl_capture_ruby_clienttest began failing on main after #2288 was merged. This PR resolves the failure and renames the container to better reflect its intended coverage (to test Python 3.10+ runtimes, which previously had TLS tracing gaps).Relevant Issues: #2290
Type of change: /kind bugfix
Test Plan: Build succeeds and verified the following locally
OpenSSLTraceTest/5.ssl_capture_ruby_clientpassesSSL_read_exandSSL_write_exlibrary functions