Skip to content

fix(.nvmrc) #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jhheider wants to merge 1 commit into from
Closed

fix(.nvmrc) #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions fixtures/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
^20.0.0
1 change: 1 addition & 0 deletions src/utils/devenv.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ Deno.test("devenv.ts", async runner => {
'pnpm.io@7.33.7',
],
[".node-version", "nodejs.org@16.16.0"],
[".nvmrc", "nodejs.org^20"],
["python-version/std/.python-version", "python.org~3.10"],
["python-version/commented/.python-version", "python.org~3.11"],
[".ruby-version", "ruby-lang.org@3.2.1"],
Expand Down
3 changes: 2 additions & 1 deletion src/utils/devenv.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ export default async function(dir: Path) {
async function version_file(path: Path, project: string) {
let s = (await path.read()).trim()
if (s.startsWith('v')) s = s.slice(1) // v prefix has no effect but is allowed
s = `${project}@${s}`
if (s.match(/^[0-9]/)) s = `@${s}` // bare numbers are single versions
s = `${project}${s}`
pkgs.push(utils.pkg.parse(s))
}

Expand Down