Revert "Bump rusqlite, update rest within constraints" #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
k passed after the revert. I will now revert the revert to verify failure. |
Member
Author
|
lol ci won’t run because it is now the same as |
mxcl
force-pushed
the
fix-embed
branch
4 times, most recently
from
d782fdd to
73b504d
Compare
Contributor
|
you could just leave the environment's openssl in and set the OPENSSL_STATIC env-var (iirc), I believe. i think that static links always, not just on self-build. |
mxcl
force-pushed
the
fix-embed
branch
4 times, most recently
from
2d60f40 to
b9c793f
Compare
This reverts commit b20b3f1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b20b3f1.
The ca-cert embed worked, but then started failing when I bumped the deps. This was not caught in CI because the CI for the PR ran against
mainthat didn't have the bump in it and the bump ran against main that didn't have the embed in it.lol!
CI did actually catch it when it ran against the merge of the PR, but there is no mechanism to communicate that to anyone (nice).
Thus I released 2.3.0 and the embed doesn’t work.
cddoes run “smoke tests” againstpkgxbefore deploying. These tests are not run in a minimal container, so nothing failed.Nice sequence for failure here.