Skip to content

Conversation

@mxcl
Copy link
Member

@mxcl mxcl commented Mar 26, 2025

No description provided.

RUN install -m 755 /pkgx/$(uname -m) /usr/local/bin/pkgx
RUN install -m 755 /pkgx/pkgm /usr/local/bin/pkgm

FROM ubuntu AS stage1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also recommend you pin the major version of the base image.

At least something like ubuntu:noble and debian:bookwork-slim to give you some control over it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm less keen to do this (at least for now, due to maintenance reasons). Users who want pinning should make their own images. Installing pkgx is trivial.

Copy link
Contributor

@felipecrs felipecrs Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New Ubuntu and Debian major versions happens on every 2 years... it shouldn't be a big problem lol.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu LTS is 2 years. Ubuntu releases a new version every April and October, iirc.

Copy link
Contributor

@felipecrs felipecrs Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but I meant how frequent the ubuntu:latest and debian:latest tag changes, which is Ubuntu LTS and Debian Stable based.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try building node with these images. It will fail.

Copy link
Contributor

@felipecrs felipecrs Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now.

This could be a problem if some user uses or extends from the pkgx docker image to do things like building their own C++ projects.

Maybe we can consider that use case a stretch. Also, doing a FROM pkgxdev/pkgx \n RUN apt-get update && apt-get install -y libstdc++ is probably not a big deal for these users.

But I agree the best would be if it "just works", without having to install extra dependencies.

I'm glad to learn that this is being addressed in the new manifests, which would mean the containers need not to ship things like libstdc++. Very exciting. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we are replacing the default image with debian which really is a breaking change

PS: the previous default image was already debian :P

Copy link
Member Author

@mxcl mxcl Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the previous image was debian yes, but it preinstalled some apt packages which the new one does not.


I’d like to be able to ship pkgx in alpine or even just a container with a kernel. But we need glibc and probably some logic in pkgx itself so it doesn't install glibc if it doesn't need to since that is excessive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree. It would be awesome (and it would make a lot of sense) to have a distroless image with just pkgx.

@mxcl mxcl force-pushed the docker branch 5 times, most recently from 4283e79 to 2a41f6b Compare March 27, 2025 13:22
@mxcl mxcl force-pushed the main branch 7 times, most recently from 744964a to 1dbdd3f Compare March 27, 2025 15:05
@mxcl mxcl force-pushed the main branch 8 times, most recently from d25caf9 to ae965fc Compare April 3, 2025 14:28
@mxcl mxcl merged commit 7bc151f into main Apr 5, 2025
4 checks passed
@mxcl mxcl deleted the docker branch April 5, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants