-
Notifications
You must be signed in to change notification settings - Fork 1.4k
more/new docker images #1157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more/new docker images #1157
Conversation
| RUN install -m 755 /pkgx/$(uname -m) /usr/local/bin/pkgx | ||
| RUN install -m 755 /pkgx/pkgm /usr/local/bin/pkgm | ||
|
|
||
| FROM ubuntu AS stage1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also recommend you pin the major version of the base image.
At least something like ubuntu:noble and debian:bookwork-slim to give you some control over it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm less keen to do this (at least for now, due to maintenance reasons). Users who want pinning should make their own images. Installing pkgx is trivial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New Ubuntu and Debian major versions happens on every 2 years... it shouldn't be a big problem lol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ubuntu LTS is 2 years. Ubuntu releases a new version every April and October, iirc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but I meant how frequent the ubuntu:latest and debian:latest tag changes, which is Ubuntu LTS and Debian Stable based.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try building node with these images. It will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now.
This could be a problem if some user uses or extends from the pkgx docker image to do things like building their own C++ projects.
Maybe we can consider that use case a stretch. Also, doing a FROM pkgxdev/pkgx \n RUN apt-get update && apt-get install -y libstdc++ is probably not a big deal for these users.
But I agree the best would be if it "just works", without having to install extra dependencies.
I'm glad to learn that this is being addressed in the new manifests, which would mean the containers need not to ship things like libstdc++. Very exciting. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now we are replacing the default image with
debianwhich really is a breaking change
PS: the previous default image was already debian :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the previous image was debian yes, but it preinstalled some apt packages which the new one does not.
I’d like to be able to ship pkgx in alpine or even just a container with a kernel. But we need glibc and probably some logic in pkgx itself so it doesn't install glibc if it doesn't need to since that is excessive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely agree. It would be awesome (and it would make a lot of sense) to have a distroless image with just pkgx.
4283e79 to
2a41f6b
Compare
744964a to
1dbdd3f
Compare
d25caf9 to
ae965fc
Compare
No description provided.