Use SUDO_HOME environment variable to derive the pkgx directory if it is set #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is set. Without this, we might work on the root user directory (as seen on Linux).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue on Linux when using
sudowhich causes the pkgx directory to be located inside the root user home directory. This seems to be due to differences in how operating systems deal withsudoand theHOMEenvironment variable. On macOS, theHOMEvariable is set to the home directory of the user calling thesudocommand, but on Fedora it is set to the root user home directory. By usingSUDO_HOMEif it set, we fix the Linux behavior to be the same as on macOS.Together with this other PR in pkgm, this fixes calling
sudo pkgm install <package>on Linux to install packages to/usr/local/bin. See full discussion for more information.