Fix GitHub issue template links#835
Conversation
tjementum
left a comment
There was a problem hiding this comment.
The pull request conventions fail because the branch name is not following conventions. It must be kebab-case in PlatformPlatform. But this will abandon the pull request, so I will just accept this and merge anyway.
But we should fix the links so they are relative, so projects pulling changes from PlatformPlatform do not get issue templates hardcoded to PlatformPlatform.
| attributes: | ||
| label: Is this bug security related? | ||
| description: Please let us know if this bug is security related. If so please consider using our [Report a security vulnerability](../security/advisories/new) form instead. | ||
| description: Please let us know if this bug is security related. If so please consider using our [Report a security vulnerability](https://github.com/platformplatform/PlatformPlatform/security/advisories/new) form instead. |
There was a problem hiding this comment.
While this will work in PlatformPlatform, it will fail in "downstream projects" are pulling changes from PlatformPlatform. If I understand the problem correct, the ../ is removing the reposiotry so lings become https://github.com/platformplatform/security/advisories/new" and not https://github.com/platformplatform/PlatformPlatform/security/advisories/new`
I think this would work
| description: Please let us know if this bug is security related. If so please consider using our [Report a security vulnerability](https://github.com/platformplatform/PlatformPlatform/security/advisories/new) form instead. | |
| description: Please let us know if this bug is security related. If so please consider using our [Report a security vulnerability](security/advisories/new) form instead. |
Summary & Motivation
Fix incorrect URLs in GitHub issue templates that resolve to broken pages. The links are missing the repository name in the path, causing URLs like https://github.com/platformplatform/blob/main/.github/CODE_OF_CONDUCT.md instead of the correct https://github.com/platformplatform/PlatformPlatform/blob/main/.github/CODE_OF_CONDUCT.md.
Checklist