Open
Conversation
Contributor
|
@freddyheppell this looks promising. i'll incorporate this into 9.1 - working some major overhauls. thanks for this! |
ef6b940 to
f363b69
Compare
|
+1 I thought it landed in 9.2 but not yet :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #686
This PR adds a new "External URL" field to each app, which allows you to specify a different URL that is externally routable. If specified, this is used to generate clickable links in the frontend, instead of the API URL. This is necessary when you're using a reverse proxy because the API URL will be the app container name (e.g.
http://sonarr:8989) behind a reverse proxy to a publicly routable URL (e.g.https://sonarr.example.org). This mirrors existing functionality in *arr-adjacent software, e.g. Overseerr.Changes:
external_urlproperty to each app's default configI have tested that an old config database (generated by the current main branch), is succesfully migrated to include the new key, and that the forms work. I haven't been able to test that the frontend link generation actually works (because my dev instance isn't actually connected to any *arrs), but the code is pretty straightforward.