Skip to content

Andrew/test timing #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayjayt merged 2 commits into from
Nov 25, 2025
Merged

Andrew/test timing #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1caae3e
Relax read/write timing a bit
ayjayt Nov 25, 2025
c45e301
Add four seconds to timeout
ayjayt Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import asyncio
import logging

import choreographer as choreo
import logistro
import pytest
import pytest_asyncio

import choreographer as choreo
from choreographer import errors

_logger = logistro.getLogger(__name__)
Expand Down Expand Up @@ -95,7 +96,7 @@ async def wrapped_test_fn(*args, **kwargs):

def pytest_configure():
# change this by command line TODO
pytest.default_timeout = 20 # type: ignore[reportAttributeAccessIssue]
pytest.default_timeout = 24 # type: ignore[reportAttributeAccessIssue]


# pytest shuts down its capture before logging/threads finish
Expand Down
5 changes: 4 additions & 1 deletion tests/test_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,10 @@ async def test_browser_send_command_with_perf(browser):

# Validate timing makes sense (write_start <= write_end <= read_end)
write_start, write_end, read_end = perf
assert write_start <= write_end <= read_end
assert write_start <= write_end
assert write_start <= read_end
# read_end is tough because it happens on a different processor
# and it might actually be somewhat skewed

perfs.append(perf)
await asyncio.sleep(0.1)
Expand Down