-
Notifications
You must be signed in to change notification settings - Fork 41
bump to AG Grid version 32.3
#328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d9956d1
7797e0a
bb415d8
66e496b
622d0ee
d7b900c
64d4b83
0ab5ff4
bc44473
db2ef2b
4401e03
15f2d48
d974941
64b1be3
fa5fedd
2ed88ec
4a3dc5d
836c274
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "dash-ag-grid", | ||
| "version": "31.3.1", | ||
| "version": "32.3.0", | ||
| "description": "Dash wrapper around AG Grid, the best interactive data grid for the web.", | ||
| "repository": { | ||
| "type": "git", | ||
|
|
@@ -25,17 +25,16 @@ | |
| "private::lint.eslint": "eslint src", | ||
| "private::lint.prettier": "prettier src --list-different --ignore-path=.prettierignore", | ||
| "lint": "run-s private::lint.*", | ||
| "test": "pytest --headless", | ||
| "dist": "npm run build && run-s pre-flight-dag-version && rimraf build dist && python setup.py sdist bdist_wheel" | ||
| "dist": "npm run build && run-s pre-flight-dag-version && python setup.py sdist bdist_wheel" | ||
| }, | ||
| "author": "Plotly <chris@plot.ly>", | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "@emotion/react": "^11.11.3", | ||
| "@emotion/styled": "^11.11.0", | ||
| "ag-grid-community": "31.3.4", | ||
| "ag-grid-enterprise": "31.3.4", | ||
| "ag-grid-react": "31.3.4", | ||
| "ag-grid-community": "32.3.4", | ||
| "ag-grid-enterprise": "32.3.4", | ||
| "ag-grid-react": "32.3.4", | ||
|
Comment on lines
-36
to
+37
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is retaining the minor and patch versions deliberate? do we want to just update to the latest minor/patch versions?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, we didnt want things to randomly get out of sync. |
||
| "@mui/icons-material": "^5.15.7", | ||
| "@mui/material": "^5.15.7", | ||
| "d3-format": "^3.1.0", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,7 +46,7 @@ import MarkdownRenderer from '../renderers/markdownRenderer'; | |
| import RowMenuRenderer from '../renderers/rowMenuRenderer'; | ||
| import {customFunctions} from '../renderers/customFunctions'; | ||
|
|
||
| import {AgGridReact} from 'ag-grid-react'; | ||
| import {AgGridReact, useGridFilter} from 'ag-grid-react'; | ||
|
|
||
| import 'ag-grid-community/styles/ag-grid.css'; | ||
| import 'ag-grid-community/styles/ag-theme-alpine.css'; | ||
|
|
@@ -488,7 +488,10 @@ export default class DashAgGrid extends Component { | |
| if (target === 'getRowId') { | ||
| return this.convertFunction(value); | ||
| } | ||
| if (target === 'getRowStyle') { | ||
| if ( | ||
| target === 'getRowStyle' && | ||
| (has('styleConditions', value) || has('defaultStyle', value)) | ||
| ) { | ||
| return this.handleDynamicStyle(value); | ||
| } | ||
| if (OBJ_OF_FUNCTIONS[target]) { | ||
|
|
@@ -604,7 +607,10 @@ export default class DashAgGrid extends Component { | |
| !equals( | ||
| {...omit(OMIT_PROP_RENDER, nextProps)}, | ||
| {...omit(OMIT_PROP_RENDER, this.props)} | ||
| ) | ||
| ) && | ||
| (nextProps?.dashRenderType !== 'internal' || | ||
| !equals(nextProps.rowData, this.props.rowData) || | ||
| !equals(nextProps.selectedRows, this.props.selectedRows)) | ||
| ) { | ||
| return true; | ||
| } | ||
|
|
@@ -617,14 +623,16 @@ export default class DashAgGrid extends Component { | |
| return true; | ||
| } | ||
| if (gridApi && !gridApi?.isDestroyed()) { | ||
| if (columnState) { | ||
| if (columnState !== this.props.columnState) { | ||
| return true; | ||
| if (nextProps?.dashRenderType !== 'internal') { | ||
| if (columnState) { | ||
| if (columnState !== this.props.columnState) { | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
| if (filterModel) { | ||
| if (!equals(filterModel, gridApi.getFilterModel())) { | ||
| return true; | ||
| if (filterModel) { | ||
| if (!equals(filterModel, gridApi.getFilterModel())) { | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
| if (selectedRows) { | ||
|
|
@@ -1170,7 +1178,7 @@ export default class DashAgGrid extends Component { | |
| cellRendererData: { | ||
| value, | ||
| colId: props.column.colId, | ||
| rowIndex: props.rowIndex, | ||
| rowIndex: props.node.sourceRowIndex, | ||
| rowId: props.node.id, | ||
| timestamp: Date.now(), | ||
| }, | ||
|
|
@@ -1494,3 +1502,6 @@ DashAgGrid.propTypes = {parentState: PropTypes.any, ..._propTypes}; | |
|
|
||
| export const propTypes = DashAgGrid.propTypes; | ||
| export const defaultProps = DashAgGrid.defaultProps; | ||
|
|
||
| var dagfuncs = (window.dash_ag_grid = window.dash_ag_grid || {}); | ||
| dagfuncs.useGridFilter = useGridFilter; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A way to pass the internal api things to the app developer. For example, this passes |
||
Uh oh!
There was an error while loading. Please reload this page.