Fix Styling for Nodes #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or `data`, this fixes an issue with `rowGrouping` not passing through the styling conditions
… always exist in the `infinite` model even if the `node` was present
gvwilson
reviewed
Dec 3, 2024
| for (const {test, style} of tests) { | ||
| if (params) { | ||
| if (params.data) { | ||
| if (params.node.id && params.node.id !== null) { |
Collaborator
Author
There was a problem hiding this comment.
When using enterprise and row grouping, the data is not present on the rows that are grouped. This was causing an issue when trying to apply styling based upon aggregate info.
However, removing data and just letting the values pass would break the app if the dev didnt have something like this in the condition: params.data ? params.data[column] : null. This was especially the case when dealing with infinite scroll.
Instead, by checking to see if the node.id exists and is not null allows an actual row to be tested, instead of rows that arent quite in existance.
gvwilson
added
community
gvwilson
approved these changes
Dec 16, 2024
ndrezn
approved these changes
Dec 16, 2024
Member
ndrezn
left a comment
ndrezn
left a comment
There was a problem hiding this comment.
👍 💃 Top-level object comparison isn't going to be sufficient... nice fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjusting styling to check if the
nodeexists, instead of testing fordata, this fixes an issue withrowGroupingnot passing through the styling conditions