Refactor: Migrate to function components #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to their own states
KoolADE85
force-pushed
the
refactor/functional-component
branch
from
f6a75ed to
38fbc5b
Compare
KoolADE85
force-pushed
the
refactor/functional-component
branch
from
38fbc5b to
a7534ee
Compare
Collaborator
|
@KoolADE85 |
KoolADE85
force-pushed
the
refactor/functional-component
branch
from
88bef0c to
224ea62
Compare
Contributor
Author
Hey @AnnMarieW that's a great call! I started this and realized it will be another fairly big diff to look at. So I'm thinking I'll do that in a separate PR. |
BSd3v
reviewed
Jul 15, 2025
BSd3v
requested changes
Jul 15, 2025
Collaborator
BSd3v
left a comment
BSd3v
left a comment
There was a problem hiding this comment.
This refactor looks like the way I had envisioned it.
I dont know if its necessary to do the check on the gridApi switch with all the other props in the useEffect as it only needs to run when the gridApi gets loaded.
BSd3v
reviewed
Jul 15, 2025
… already - adjusting tests in the event the grid takes a bit to render - fixed issue with selectedRows triggering uneccessarily
BSd3v
approved these changes
Jul 15, 2025
Collaborator
BSd3v
left a comment
BSd3v
left a comment
There was a problem hiding this comment.
Looks good to me. All tests are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a pure refactor from class to function components.
There is no functionality change. All automated tests continue to pass, and all example apps in
docs/have been manually confirmed as working.