Skip to content

Conversation

@andre996
Copy link
Contributor

issue #412

@gvwilson gvwilson added feature something new community community contribution P2 considered for next cycle labels Oct 28, 2025
@AnnMarieW
Copy link
Collaborator

I ran this and it works fine. Solves the issue.

@BSd3v
Copy link
Collaborator

BSd3v commented Dec 5, 2025

@andre996

Please also add a changelog.

Removed duplicate entry for issue plotly#412 in the changelog.
@andre996
Copy link
Contributor Author

andre996 commented Dec 5, 2025

@BSd3v Added.

@BSd3v
Copy link
Collaborator

BSd3v commented Dec 5, 2025

Great, thank you.

Could you please add a test for this?

@andre996
Copy link
Contributor Author

andre996 commented Dec 5, 2025

@BSd3v I add a test, I would like you to review it, I'm not 100% sure about it...I'm open to any feedback.

Comment on lines 304 to 315
# Uncheck "Select All"
dash_duo.find_element('.ag-set-filter-list .ag-set-filter-item .ag-checkbox-input').click()

# Select "24/08/2008"
set_filter_items = dash_duo.find_elements('.ag-set-filter-list .ag-virtual-list-item')
for item in set_filter_items:
if "24/08/2008" in item.text:
item.find_element_by_css_selector('.ag-checkbox-input').click()
break

# Apply
dash_duo.find_element('button[ref="applyFilterButton"]').click()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that this is executing too fast, you need to make sure that the options are actually showing before trying to click or interact.

You can use wait_until or something similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will try that! Thanks!

@andre996 andre996 requested a review from BSd3v December 15, 2025 17:48
Copy link
Collaborator

@BSd3v BSd3v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💃

@BSd3v BSd3v merged commit c87759d into plotly:main Dec 18, 2025
3 checks passed
BSd3v added a commit to BSd3v/dash-ag-grid-real that referenced this pull request Dec 19, 2025
@BSd3v BSd3v mentioned this pull request Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community community contribution feature something new P2 considered for next cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-Column Filter: Nested comparator functions not properly recognized in filterParams

5 participants