-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Building support for decoupling Dash from Flask and supporting Quart / FastAPI servers #3430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BSd3v
wants to merge
94
commits into
plotly:dev
Choose a base branch
from
BSd3v:bring-your-own-server
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,712
−501
Open
Changes from all commits
Commits
Show all changes
94 commits
Select commit
Hold shift + click to select a range
c457ab7
initial push
BSd3v 4ebc657
work to modularize the dash eco-system and decouple from Flask
BSd3v 9dff791
fix favicon
BSd3v c319b18
removing changelog entry
BSd3v 7de2a41
fixing issue with debug true for FastAPI
BSd3v 2cd769e
fixing `catchall` for path routes
BSd3v 686f32f
fixing pages for use with `fastapi`
BSd3v 660e257
fixing issue with flask pages
BSd3v 581f8a5
Merge pull request #3 from BSd3v/modularize-dash-server
BSd3v 9eb9dd0
Merge branch 'dev' into bring-your-own-server
BSd3v 0fa5c99
fixing for lint
BSd3v 1088331
fixing issue with failing test due to `endpoint` name
BSd3v 4920e33
fixing `run` command to trigger `devtools` properly
BSd3v 9ffba5a
fixing issue with lint and debug ui
BSd3v 908aacd
fixing issue with `_app` when using dispatch, need to keep in context
BSd3v 9491c7f
fixing issue with catchall
BSd3v 39ad7bd
fixing issue with args and cancelling callbacks
BSd3v 7bf69a7
fixing issues with pages metadata and flaky tests
BSd3v 10681dc
fixing issues with relativate paths
BSd3v 4944d6d
∙ - initial quart factory
3b0f47e
Quart factory ready
1112f77
fixing for lint
BSd3v 8c52bbb
fixing issue with apps overwriting other paths
BSd3v aabeeb7
removing print
BSd3v 5659cd7
cleanup
b05e376
reverting `render_index` -> `index` and making catch for outside of a…
BSd3v ed0dc3b
∙ - initial quart factory
141527c
Quart factory ready
3e38d41
fixing `prune_errors` test
BSd3v 381fb0c
adjustments for flask api_endpoint declared in callback defs
BSd3v a27927a
updated QuartRequestAdapter & QuartFactory to latest changes
fbc3935
checkout
1824e11
Removed redundant Response return
b14f6d2
fix for fastapi `api_endpoint` registering
BSd3v fbefbc9
Merge pull request #4 from chgiesse/quart-factory
BSd3v 5ef796b
shifting from `server_factory` to `backend`
BSd3v a4ca566
adding missing files
BSd3v 708773f
fixing issue with server not declared
BSd3v b7bceba
Update dash/dash.py
BSd3v 9873079
Update dash/dash.py
BSd3v 9f4d291
Update dash/backend/quart.py
BSd3v da86e86
Update dash/dash.py
BSd3v 4c60740
Update dash/dash.py
BSd3v 84cb5e5
update for caller_name
BSd3v 29cf823
Update dash/dash.py
BSd3v 5d0f4dc
Update dash/dash.py
BSd3v 86f4528
adjustments for matching types
BSd3v 2a88385
Update dash/backend/registry.py
BSd3v df76ed6
Merge branch 'factory-backend' of github.com:BSd3v/dash into factory-…
BSd3v bc51c0d
Update dash/backend/registry.py
BSd3v 1b4d0d3
fixing another type check
BSd3v f867f98
fixing for lint
BSd3v 0ed81ce
fixing failing test
BSd3v 6bd342a
fixing issue with fastapi and component suites
BSd3v b1c9953
adjustments to fix issues with caller_name and init the app a couple …
BSd3v bd40b56
adjustments for failing tests
BSd3v 4e50430
format dash
BSd3v 0d32e65
removing `FlaskDashServer` from import and using `get_backend('flask'…
BSd3v 1b3f61e
reverting change to callable(title) process
BSd3v c6805b5
fixing for lint
BSd3v 8c78089
adding custom error handling per backend, tests and adjustments to th…
BSd3v 5211f6f
adjusments for formatting
BSd3v 6a34208
adjustment to retest backend
BSd3v 1a2b531
adding missing reqs association
BSd3v 465e45e
fixing minor linting issues
BSd3v c43a583
Add global Request Adapter (#6)
chgiesse c4795ed
fixes for failing tests
BSd3v 567d0f8
fixing formatting
BSd3v a855c6d
fixing issues
BSd3v 79afb0b
fixing async validation
BSd3v 77e22a3
adjustments for request_adapter
BSd3v f7331d3
adding test for custom dash server
BSd3v 8b58cf4
fixing issue with `request_adapter`
BSd3v b7d4af2
adjusting error handling for fastapi
BSd3v 4cf4686
adjustments for handling issues with `debug` for `fastapi`
BSd3v dfe0ac7
fixing for lint
BSd3v cd02cc5
adjustment for delayed config
BSd3v 16b3c9e
fix typing error
BSd3v 493d150
fixes for pages
BSd3v 26f01b2
Merge branch 'dev' into bring-your-own-server
BSd3v a10f86b
Decouple flask (#7)
chgiesse 02e0be5
Merge branch 'dev' into bring-your-own-server
BSd3v 39b1096
Merge branch 'dev' into bring-your-own-server
BSd3v acc0179
Merge branch 'dev' into bring-your-own-server
BSd3v 99f9ad6
Merge remote-tracking branch 'remote/dev' into bring-your-own-server
BSd3v 3e22e93
Update dash/backends/_utils.py
BSd3v f5dfc07
updates for formatting
BSd3v ac2ef7d
Merge branch 'bring-your-own-server' of github.com:BSd3v/dash into br…
BSd3v 907aba2
adjusting favicon to be consistent between all and using `make_respon…
BSd3v 9852bf6
renaming `dispatch` to `serve_callback`
BSd3v d961899
adding a config description for `debug=True`
BSd3v 8f03875
fastapi requires `server` to be defined
BSd3v c87e1a7
changing import errors
BSd3v cad3cba
making the path name for the config file more dynamic in order to not…
BSd3v File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be a future pain point to update existing hooks, maybe we can try adding a flask.Response converter in the adapter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the
self.backend.make_responsewhich uses the server adapters.