commit some tweaks made in advance of the agu demo#31
Open
commit some tweaks made in advance of the agu demo#31
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
There was a problem hiding this comment.
Thanks for these updates Jack. My comments based on the review of the ReviewNB diff app (very cool and helpful tool!!):
- I would keep the in-cell comments from the original notebook, I think these are helpful and it's good form to have comments in code
- RESULTS section added at the end, a very nice addition to see the time/compute processing for the two cases. However, I would recommend adding a sentence stating this following Results section is optional to the workflow, and is meant as exploratory tool to compare downloads speeds for two equivalent L4 MUR subsets accessed from the PODAAC s3 storage (netCDF) in Earthdata Cloud in AWS, as well as the AWS Registry of Open Data MUR version (Zarr). Basically just add a bit more context for the notebook user.
- can you cluster the imports at the top and add brief comments what each import or cluster is used for? e.g. plotting, data access in s3, etc etc. an example is here https://nasa-openscapes.github.io/2021-Cloud-Workshop-AGU/tutorials/04_On-Prem_Cloud.html
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some code improvements + simplifications to the SWOT-EA-2021 notebook inside this branch. I had to make edits before recording parts of it for AGU, and some of the tweaks are worth merging into the main branch IMO.
I added a few more cells to the end of the workflow to compare downloads speeds for two equivalent L4 MUR subsets accessed from our s3 storage (netCDF) as well as the aws open reg (Zarr). I was sorta surprised by the result; comparable download times over the admittedly very small time/space coverage. Still neat to see tho.