fix(prepull): Add toleration to run on tainted nodes#62
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM. The change from copying workbench tolerations to using a universal toleration (Operator: Exists) is the right approach for a prepull daemonset - it ensures images are pulled on all nodes regardless of taints, which is the desired behavior.
The implementation is clean: removes conditional logic in favor of a simple, declarative toleration that's inline with the pod spec.
Controller checklist:
- Reconciliation remains idempotent
- Error handling unchanged
- Config flow unaffected (this is actually removing a dependency on workbench tolerations)
ian-flores
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a toleration to run on all nodes, regardless of taint. The prepull daemonset pulls images for ptd products as well as session images so it should run everywhere.