fix: adjust layout and spacing in footer and project card components … #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for improved responsiveness
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the layout and spacing of the Footer and ProjectCard UI components to improve design consistency and responsiveness.
- Switched badge container rounding in
ProjectCardto apply only on small screens - Removed blur effect and tightened grid gaps in
Footer - Adjusted padding and margin utilities for consistent footer spacing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/ui/project-card.tsx | Changed rounding breakpoint to max-sm:rounded-none for badges |
| src/components/ui/footer.tsx | Removed blur, set uniform grid gap, and updated padding/margin |
Comments suppressed due to low confidence (2)
src/components/ui/footer.tsx:62
- By replacing
gap-8andxl:gap-8withgap-0, the grid no longer has spacing on larger screens, which may collapse columns together. Consider reintroducing gap utilities for default or xl breakpoints to restore intended spacing.
<div className="grid w-full max-w-6xl max-sm:gap-0 gap-0 xl:grid-cols-3">
src/components/ui/footer.tsx:70
- The removal of
sm:mt-10eliminates the top margin on small and medium screens, potentially reducing visual separation. If vertical spacing is desired here, re-add an appropriatemt-*utility for the intended breakpoint.
<div className="grid grid-cols-2 max-sm:gap-0 gap-8 sm:grid-cols-3 md:col-span-2 xl:mt-0 max-sm:px-4 max-sm:border-b px-6 py-12">
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the UI components for improved design consistency and minor adjustments to the layout and styling. The changes primarily focus on the
FooterandProjectCardcomponents.Footer Component Updates:
gapproperty in the grid layout togap-0for a more compact design.blureffect from the top decorative line for a cleaner appearance.ProjectCard Component Updates:
max-sm:rounded-noneclass to the badge container for small screens.…for improved responsiveness