file_contents_sorter: add --group-cases-together -- a better case-insensitive sort#1186
Closed
programmerjake wants to merge 1 commit intopre-commit:mainfrom
Closed
Conversation
571c8d1 to
1d6bd5f
Compare
Member
|
please discuss features first before spending time on them I'm not really looking to add more options especially when I can't possibly think of a name for them or explain in simple terms how they work so I'm going to decline this sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
--group-cases-togetheroption groups lines that differ only in case together, so e.g.:is sorted to:
instead of:
It also works with
--unique.The
--ignore-caseoption keeps lines that differ only in case in the original sorted order, whereas the new option will sort them (and remove duplicates if you pass--unique).I added a new option instead of changing
--ignore-casefor backward compatibility with existing commit hooks so it doesn't break CI.better naming suggestions are welcome.