[issue-307] add 2 extra (on left and right) dots out of zoomed box#308
[issue-307] add 2 extra (on left and right) dots out of zoomed box#308lemikhovalex wants to merge 5 commits intopredict-idlab:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
==========================================
- Coverage 96.49% 95.97% -0.52%
==========================================
Files 14 14
Lines 1141 1143 +2
==========================================
- Hits 1101 1097 -4
- Misses 40 46 +6 ☔ View full report in Codecov by Sentry. |
| # Search the index-positions | ||
| start_idx = bisect.bisect_left(hf_trace_data["x"], start) | ||
| end_idx = bisect.bisect_right(hf_trace_data["x"], end) | ||
| start_idx = max(0, start_idx - 1) |
There was a problem hiding this comment.
We should certainly add some documentation / issue reference to which this is performed.
There was a problem hiding this comment.
added to CHANGELOG.md. Do I need to mention it anywhere else?
| assert (x1 - x0) < 10 | ||
| assert len(out[1]["x"]) == 1000 | ||
| assert out[-1]["x"][0] >= 100 | ||
| assert out[-1]["x"][0] >= 99 |
There was a problem hiding this comment.
So here, you increase (i.e. lower) the left boundary, because (when possible) a datapoint to the left is added. Why is there no need to increase the right boundary?
There was a problem hiding this comment.
(maybe because of a small rounding error with log?)
There was a problem hiding this comment.
You are right!
-> end_idx = bisect.bisect_right(hf_trace_data["x"], end)
-> end == 49999.99999999999
Nevertheless alter boundary. It would benefit readability
|
Hello guys :] Can we get this baby merged? It would help me tremendously |
jonasvdd
changed the title
|
related: #307 |
I support that :) It would me help a lot! |
|
Will tackle this PR in #343 |
5 participants
No description provided.