You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a quick proof of concept to show a CSS-based approach to hiding overflowing items. It uses flex-wrap to wrap them onto the next line, along with overflow: hidden and an explicit height to clip subsequent lines.
In addition, this shows how we can use CSS scroll-state container queries to determine whether or not to show the tab icons and overflow menu initially.
This is a minimal and quick PR - after the initial render, all the logic is still done by JS-based width calculations.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
integration-tests: recommended
iansan5653
had a problem deploying
to
github-pages
GitHub Actions
Failure
This is just a quick proof of concept to show a CSS-based approach to hiding overflowing items. It uses
flex-wrapto wrap them onto the next line, along withoverflow: hiddenand an explicitheightto clip subsequent lines.In addition, this shows how we can use CSS
scroll-statecontainer queries to determine whether or not to show the tab icons and overflow menu initially.This is a minimal and quick PR - after the initial render, all the logic is still done by JS-based width calculations.
For more context, see https://github.com/github/primer/issues/6291#issuecomment-3861950186
Closes #
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist