You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses review feedback from PR #7510 to improve the SettingMaxHeight story implementation for better clarity and e2e/VRT test compatibility.
Changelog
Changed
Renamed confirmButtonRef to closeButtonRef in SettingMaxHeight story to accurately reflect the element it references
Updated SettingMaxHeight story to accept Storybook Args parameter, enabling e2e/VRT tests to control overlay state via args: {open: true}
Updated render condition to isOpen || open to support both internal state and Storybook args
Updated useFocusTrap disabled condition to !isOpen && !open to match render logic
Rollout strategy
Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why
Testing & Reviewing
Story now follows the same pattern as DialogOverlay and DropdownOverlay for args handling. Verify the story renders correctly in Storybook with args: {open: true}.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
CopilotAI
changed the title
[WIP] Fix max-height exceeding viewport height in Overlay and ActionMenu
Apply review feedback: rename confirmButtonRef and add Storybook args support
Feb 10, 2026
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
integration-tests: recommended
francinelucca
added
update snapshots
Addresses review feedback from PR #7510 to improve the
SettingMaxHeightstory implementation for better clarity and e2e/VRT test compatibility.Changelog
Changed
confirmButtonReftocloseButtonRefinSettingMaxHeightstory to accurately reflect the element it referencesSettingMaxHeightstory to accept StorybookArgsparameter, enabling e2e/VRT tests to control overlay state viaargs: {open: true}isOpen || opento support both internal state and Storybook argsuseFocusTrapdisabled condition to!isOpen && !opento match render logicRollout strategy
Testing & Reviewing
Story now follows the same pattern as
DialogOverlayandDropdownOverlayfor args handling. Verify the story renders correctly in Storybook withargs: {open: true}.Merge checklist
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.