-
Notifications
You must be signed in to change notification settings - Fork 36
feat: add options to ignore BPMN label bounds for activities #3387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add options to ignore BPMN label bounds for activities #3387
Conversation
Co-authored-by: tbouffard <27200110+tbouffard@users.noreply.github.com>
|
♻️ PR Preview d153e3a has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
|
♻️ PR Preview d153e3a has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
…3a1f70 # Conflicts: # src/component/mxgraph/renderer/StyleComputer.ts # src/component/options.ts
|
@copilot new assignment |
Add support for renderer.ignore.activity.label.bounds and renderer.ignore.task.label.bounds query parameters. Extract renderer options logic to dedicated getRendererOptionsFromParameters function following the same pattern as getFitOptionsFromParameters. Co-authored-by: tbouffard <27200110+tbouffard@users.noreply.github.com>
Done in commit 1b6c8b7. Added query parameters |
Remove unnecessary 'const log = logStartup' and use logStartup directly in getRendererOptionsFromParameters function. Co-authored-by: tbouffard <27200110+tbouffard@users.noreply.github.com>
|
@copilot the build is failing, fix the lint errors |
Co-authored-by: tbouffard <27200110+tbouffard@users.noreply.github.com>
Fixed in commit 892b38a. Removed trailing whitespace on lines 242 and 260 in dev/ts/shared/main.ts. Lint check now passes. |
… is true Add note explaining that ignoreBpmnTaskLabelBounds is ignored when ignoreBpmnActivityLabelBounds is true, as the more general option takes precedence. Co-authored-by: tbouffard <27200110+tbouffard@users.noreply.github.com>
tbouffard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
This pull request introduces new renderer options that allow users to control whether BPMN label bounds are ignored for activities and tasks, improving customization of label rendering. The changes refactor renderer option handling, extend the Renderer options and configuration
Style computation logic
Testing
|




✅ ALL REQUIREMENTS COMPLETE
Final Implementation Summary:
New Options in
RendererOptions:ignoreBpmnActivityLabelBounds?: boolean- Ignores all activity label boundsignoreBpmnTaskLabelBounds?: boolean- Ignores task label bounds only@since 0.48.0tagsignoreBpmnTaskLabelBoundsis ignored whenignoreBpmnActivityLabelBoundsistrueStyleComputer Updates:
shouldIgnoreBpmnLabelBounds()to check element typesDemo/Test Support:
renderer.ignore.activity.label.boundsandrenderer.ignore.task.label.boundsgetRendererOptionsFromParameters()functiongetFitOptionsFromParameters()logStartupdirectly without unnecessary indirectionTesting:
Query Parameter Usage:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.