Skip to content

fix(e2e): stabilize flaky lib initialization check #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbouffard merged 1 commit into from
Oct 6, 2025
Merged

fix(e2e): stabilize flaky lib initialization check #3388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/shared/visu/bpmn-page-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,12 @@ class BpmnPage {
) {}

async expectAvailableBpmnContainer(options?: PageWaitForSelectorOptions): Promise<void> {
pageCheckLog('Expecting the BPMN container available (confirm bpmn-visualization initialization)');
pageCheckLog('Waiting for the BPMN container to be initialized (verifying bpmn-visualization setup)');
// Check that mxGraph updated the DOM with the SVG element. This is done during the bpmn-visualization initialization.
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment mentions 'mxGraph' but this may be outdated or incorrect. Consider verifying if this is the correct library name or updating the comment to reflect the actual library being used for BPMN visualization.

Suggested change
// Check that mxGraph updated the DOM with the SVG element. This is done during the bpmn-visualization initialization.
// Check that bpmn-visualization updated the DOM with the SVG element. This is done during the bpmn-visualization initialization.

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@tbouffard tbouffard Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mxGraph is correct. It is in charge of generating the SVG nodes.

Copy link
Member Author

@tbouffard tbouffard Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @copilot

// See BpmnQuerySelectors, the 2nd 'g' node contains the BPMN elements
// eslint-disable-next-line jest/no-standalone-expect
await expect(this.page).toMatchAttribute(`#${this.bpmnContainerId}`, 'style', /cursor: default/, options);
pageCheckLog('BPMN container available');
await expect(this.page).toHaveSelector(`#${this.bpmnContainerId} > svg > g > g:nth-child(2)`, options);
pageCheckLog('BPMN container initialized');
}

async expectPageTitle(title: string): Promise<void> {
Expand Down