feat: add dispose method to BpmnVisualization #3415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a dispose() method to properly release resources and clean up when a BpmnVisualization instance is no longer needed. Key changes: - Add Disposable interface for objects that can free resources - Implement dispose() in BpmnVisualization to clean up graph and navigation resources - Add dispose() to NavigationImpl and ZoomSupport to properly remove event listeners - Prevent loading after disposal with clear error message - Add integration tests to verify dispose functionality This is particularly useful for: - Removing BPMN diagrams from the page and freeing memory - Cleaning up or unmounting components that use BpmnVisualization - Preventing memory leaks from event listeners in long-running applications
tbouffard
added
enhancement
|
♻️ PR Preview 7929948 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 7929948 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
tbouffard
added
the
skip CI e2e tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dispose() method to properly release resources and clean up when a BpmnVisualization instance is no longer needed.
Key changes:
This is particularly useful for: