RHAIENG-1795: test using gateway config as fallback for constructing dashboard url#993
RHAIENG-1795: test using gateway config as fallback for constructing dashboard url#993kryanbeane wants to merge 1 commit intomainfrom
Conversation
|
@kryanbeane: This pull request references RHAIENG-1795 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (45.45%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
==========================================
- Coverage 95.87% 95.65% -0.22%
==========================================
Files 22 22
Lines 2132 2141 +9
==========================================
+ Hits 2044 2048 +4
- Misses 88 93 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issue link
RHAIENG-1795
What changes have been made
Added fallback to use gateway config for constructing dashboard url
Verification steps
Hard to verify - @CathalOConnorRH has verified I believe that without usual gateway object, this works as an alternative
Checks