Skip to content

Comments

RHAIENG-1795: test using gateway config as fallback for constructing dashboard url#993

Open
kryanbeane wants to merge 1 commit intomainfrom
test-gateway-config-url-generation
Open

RHAIENG-1795: test using gateway config as fallback for constructing dashboard url#993
kryanbeane wants to merge 1 commit intomainfrom
test-gateway-config-url-generation

Conversation

@kryanbeane
Copy link
Contributor

Issue link

RHAIENG-1795

What changes have been made

Added fallback to use gateway config for constructing dashboard url

Verification steps

Hard to verify - @CathalOConnorRH has verified I believe that without usual gateway object, this works as an alternative

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 28, 2026

@kryanbeane: This pull request references RHAIENG-1795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Issue link

RHAIENG-1795

What changes have been made

Added fallback to use gateway config for constructing dashboard url

Verification steps

Hard to verify - @CathalOConnorRH has verified I believe that without usual gateway object, this works as an alternative

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fiona-waters for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.65%. Comparing base (17485ee) to head (5d3dcca).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/codeflare_sdk/ray/cluster/cluster.py 45.45% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (45.45%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
- Coverage   95.87%   95.65%   -0.22%     
==========================================
  Files          22       22              
  Lines        2132     2141       +9     
==========================================
+ Hits         2044     2048       +4     
- Misses         88       93       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants