Skip to content

Comments

RHOAIENG-38670: Add pre and post upgrade authentication tests#997

Open
kryanbeane wants to merge 1 commit intoproject-codeflare:mainfrom
kryanbeane:RHOAIENG-38670
Open

RHOAIENG-38670: Add pre and post upgrade authentication tests#997
kryanbeane wants to merge 1 commit intoproject-codeflare:mainfrom
kryanbeane:RHOAIENG-38670

Conversation

@kryanbeane
Copy link
Contributor

Issue link

RHOAIENG-37986

What changes have been made

Added a new test file to the upgrade tests. One for pre upgrade and one for post upgrade. In both cases, it is checked that unauthenticated requests don't succeed. And authenticated requests succeed

Verification steps

TODO

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 4, 2026

@kryanbeane: This pull request references RHOAIENG-38670 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.22." or "openshift-4.22.", but it targets "rhoai-3.3" instead.

Details

In response to this:

Issue link

RHOAIENG-37986

What changes have been made

Added a new test file to the upgrade tests. One for pre upgrade and one for post upgrade. In both cases, it is checked that unauthenticated requests don't succeed. And authenticated requests succeed

Verification steps

TODO

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kryanbeane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.96%. Comparing base (b4b26b9) to head (66548c3).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
+ Coverage   95.91%   95.96%   +0.05%     
==========================================
  Files          22       23       +1     
  Lines        2130     2208      +78     
==========================================
+ Hits         2043     2119      +76     
- Misses         87       89       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants